-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to create extendr package infrastructure #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we add src/.gitignore
?
*.o
*.so
*.dll
target
Cargo.lock
https://github.com/extendr/helloextendr/blob/main/src/.gitignore
I can add |
Ah, I agree we should leave |
Also, these are not included in
|
I was looking here, since I'm copying helloextendr basically: |
|
Thanks, looks good now. Let me try creating a package using this before approving. |
@clauswilke, |
Very nice. I fully intend to use this to generate some example packages |
@Ilia-Kosenkov Sure, no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clauswilke,
It works fine under Windows.
However, I suggest using to_toml
to generate the skeleton Cargo.toml
(see comments).
@clauswilke, |
@Ilia-Kosenkov I think it's easier if I merge this and then you make a separate PR for the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, go ahead.
I have added a function
use_extendr()
to add an extendr scaffolding to an R package. There is currently no unit testing for this, it's a bit difficult to set up.@Ilia-Kosenkov Could you try this on Windows?