feat: add PushSecret and DeleteSecret to onepassword provider #2646

bthuilot · 2023-08-23T21:15:40Z

Problem Statement

Currently the onepassword provider does not implement the PushSecret functionality.

Related Issue

Proposed Changes

implement the methods PushSecret and DeleteSecret for the onepassword provider to conform to the esv1beta1.SecretsClient interface

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

paul-the-alien

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

Useful commands:

make fmt: Formats the code
make check-diff: Ensures the branch is clean
make reviewable: Ensures a PR is ready for review

acelinkio · 2023-08-24T02:26:39Z

Don't forget to update support for push/delete!

external-secrets/docs/introduction/stability-support.md

Line 75 in 77a70d0

    
           | 1Password                 |      x       |              |                      |                         |        x         |             |                             |

sonarcloud · 2023-08-29T00:35:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
0.0% Duplication

acelinkio · 2023-09-18T17:19:56Z

Hey @gusfcarvalho any chance this can be reviewed in more detail? Would love to see 1password support mature.

Thanks!

shuheiktgw · 2023-10-07T23:03:24Z

Hi @bthuilot 👋 Thank you for the PR and sorry that we could not review the PR in a timely fashion. Something seems to be wired with the commits. Would you fix them so that we can review the PR?

bthuilot · 2023-10-14T14:39:14Z

hey @shuheiktgw yeah this was probably because the first time i updated i did a weird rebase, i just merged from the upstream but let me know if something is still up and I can take a look. thanks!

acelinkio · 2023-11-04T20:16:46Z

Any updates on this? Would love to see this merged!

Signed-off-by: Bryce Thuilot <bryce@thuilot.io>

sonarcloud · 2023-11-10T19:32:39Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
0.0% Duplication

bthuilot · 2023-11-10T19:37:57Z

hey @shuheiktgw ive gone ahead and collapsed all commits into one, and updated with the changes to the PushSecret interface. and to echo @acelinkio , would love if you could give it another review 😁

onedr0p · 2023-12-19T16:46:28Z

I just came across a use case for this and it would be awesome to see this reviewed and merged. Thanks! 🚀

doonga · 2023-12-19T20:08:26Z

I definitely have a use case for this and would like to see it added.
Thanks!

pkg/provider/onepassword/onepassword.go

Skarlso · 2023-12-21T10:48:28Z

pkg/provider/onepassword/onepassword.go

-func (provider *ProviderOnePassword) PushSecret(_ context.Context, _ *corev1.Secret, _ esv1beta1.PushSecretData) error {
-	return fmt.Errorf("not implemented")
+func (provider *ProviderOnePassword) PushSecret(_ context.Context, secret *corev1.Secret, ref esv1beta1.PushSecretData) error {
+	val, ok := secret.Data[ref.GetSecretKey()]


You need to update your branch. :) GetSecretKey is no longer a required value. And it's possible to push a whole secret now as is. So defining a key might not be required as is.

It doesn't mean that it's not required here, but keep in mind that people might want to push the entire secret to 1password as is.

pkg/provider/onepassword/onepassword.go

pkg/provider/onepassword/onepassword_test.go

Skarlso

I have some comments and concerns. Otherwise, great job. I love the tests! I would also love some more documentation about the usage.

Thanks! :)

patkarcarasent · 2023-12-28T10:07:11Z

Great job on this one, I have the fork running right now and it's working great, looking forward to getting it merged so I can go back to mainline.

bthuilot

hey @Skarlso just responded to some of your comments, and going to start on the changes from the other ones now that the holidays are wrapping up.

Appreciate the feedback and please let me know your thoughts on some of my answers!

pkg/provider/onepassword/onepassword.go

Skarlso · 2023-12-30T22:22:58Z

Nice, thanks! :)

Signed-off-by: Bryce Thuilot <bryce@thuilot.io>

bthuilot · 2024-01-04T01:00:10Z

hey @Skarlso updated the PR, let me know when you get a chance to review

Skarlso · 2024-01-04T07:13:46Z

@bthuilot Can you please take a look at the 6 new Sonar issues? :)

That's why they had the constants for errors I guess. You can still wrap the error using an error format or something like that.

After that I think this is great work and job done. :)

Signed-off-by: Bryce Thuilot <bryce@thuilot.io>

sonarcloud · 2024-01-04T18:27:32Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

bthuilot · 2024-01-04T18:28:23Z

@Skarlso fixed those issues, thank you again for taking the time to review!

Skarlso · 2024-01-04T18:28:48Z

Nice! Thanks!! No problem. :)

Skarlso · 2024-01-04T18:30:25Z

/ok-to-test sha=35dac81

Skarlso · 2024-01-04T18:37:00Z

Thank you very much for this feature! Great job implementing it, and again, lovely tests. :) Thanks!

…al-secrets#2646) * feat: add PushSecret and DeleteSecret to onepassword provider Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: clean code based on suggestions Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: make suggested sonar cube changes Signed-off-by: Bryce Thuilot <bryce@thuilot.io> --------- Signed-off-by: Bryce Thuilot <bryce@thuilot.io> Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

…al-secrets#2646) * feat: add PushSecret and DeleteSecret to onepassword provider Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: clean code based on suggestions Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: make suggested sonar cube changes Signed-off-by: Bryce Thuilot <bryce@thuilot.io> --------- Signed-off-by: Bryce Thuilot <bryce@thuilot.io>

…al-secrets#2646) * feat: add PushSecret and DeleteSecret to onepassword provider Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: clean code based on suggestions Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: make suggested sonar cube changes Signed-off-by: Bryce Thuilot <bryce@thuilot.io> --------- Signed-off-by: Bryce Thuilot <bryce@thuilot.io> Signed-off-by: Mike Serchenia <michael_serchenia@epam.com>

…al-secrets#2646) * feat: add PushSecret and DeleteSecret to onepassword provider Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: clean code based on suggestions Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: make suggested sonar cube changes Signed-off-by: Bryce Thuilot <bryce@thuilot.io> --------- Signed-off-by: Bryce Thuilot <bryce@thuilot.io> Signed-off-by: Sai Charan Godasi <saicharangodasi@Sais-MacBook-Air.local>

…al-secrets#2646) * feat: add PushSecret and DeleteSecret to onepassword provider Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: clean code based on suggestions Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: make suggested sonar cube changes Signed-off-by: Bryce Thuilot <bryce@thuilot.io> --------- Signed-off-by: Bryce Thuilot <bryce@thuilot.io> Signed-off-by: Mike Serchenia <michael_serchenia@epam.com>

…al-secrets#2646) * feat: add PushSecret and DeleteSecret to onepassword provider Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: clean code based on suggestions Signed-off-by: Bryce Thuilot <bryce@thuilot.io> * refactor: make suggested sonar cube changes Signed-off-by: Bryce Thuilot <bryce@thuilot.io> --------- Signed-off-by: Bryce Thuilot <bryce@thuilot.io>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://togithub.com/external-secrets/external-secrets) | patch | `0.9.11` -> `0.9.12` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.9.12`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.9.12) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.9.11...v0.9.12) Image: `ghcr.io/external-secrets/external-secrets:v0.9.12` Image: `ghcr.io/external-secrets/external-secrets:v0.9.12-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.12-ubi-boringssl` #### What's Changed - bump 0.9.11 by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#2982 - chore(deps): bump golang from 1.20.1 to 1.21.5 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#2976 - fix: chart: update cert-manager cert. duration by [@Tycale](https://togithub.com/Tycale) in [external-secrets/external-secrets#2986 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#2988 - Fix value name by [@Aransh](https://togithub.com/Aransh) in [external-secrets/external-secrets#2985 - feat: add ability to define flavour for tag by [@A1994SC](https://togithub.com/A1994SC) in [external-secrets/external-secrets#2881 - Fix typo in pushsecrets docs by [@matusf](https://togithub.com/matusf) in [external-secrets/external-secrets#2998 - feat: add PushSecret and DeleteSecret to onepassword provider by [@bthuilot](https://togithub.com/bthuilot) in [external-secrets/external-secrets#2646 - Configure codecov by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#2995 - added some example for v2 literal templating by [@rpasche](https://togithub.com/rpasche) in [external-secrets/external-secrets#3007 - Akeyless Provider - Add support for Certificate items by [@barucoh](https://togithub.com/barucoh) in [external-secrets/external-secrets#3013 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3005 - Feat/allow keeper to work with complex types by [@ppodevlabs](https://togithub.com/ppodevlabs) in [external-secrets/external-secrets#3016 - docs: update controller reconcile error rule by [@aslafy-z](https://togithub.com/aslafy-z) in [external-secrets/external-secrets#3021 - Issue/2965 - Documentation does not reflect latest changes for datafrom for IBM Secret Manager by [@fdberlking](https://togithub.com/fdberlking) in [external-secrets/external-secrets#3010 - doc: update bitwarden-cli image & version by [@charlesthomas](https://togithub.com/charlesthomas) in [external-secrets/external-secrets#2971 - Update the ExternalSecret status even when data is empty by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#2927 - grammar - it is by [@aviadkray](https://togithub.com/aviadkray) in [external-secrets/external-secrets#2991 - gramar2 - intuitive not intuative by [@aviadkray](https://togithub.com/aviadkray) in [external-secrets/external-secrets#2992 - docs: add command to install CRDs using kustomize by [@PeterStolz](https://togithub.com/PeterStolz) in [external-secrets/external-secrets#3023 - Validator by [@Mehrbod2002](https://togithub.com/Mehrbod2002) in [external-secrets/external-secrets#3003 - chore(deps): bump golang from 1.21.5 to 1.21.6 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3024 - feat: set default namespace on vault secretStore (namespaced ressource) by [@M0NsTeRRR](https://togithub.com/M0NsTeRRR) in [external-secrets/external-secrets#2869 - Create OSSF scorecard job by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3032 - feat: add support for Hashicorp Vault mTLS by [@rodrigorfk](https://togithub.com/rodrigorfk) in [external-secrets/external-secrets#3018 - \[Snyk] Fix for 5 vulnerabilities by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3036 - chore(deps): bump tornado from 6.3.3 to 6.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3051 - chore(deps): bump click from 8.1.3 to 8.1.7 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3050 - chore(deps): bump actions/cache from 3.3.3 to 4.0.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3049 - chore(deps): bump github/codeql-action from 2.2.4 to 3.23.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3048 - chore(deps): bump markupsafe from 2.1.1 to 2.1.3 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3047 - chore(deps): bump mkdocs-macros-plugin from 0.7.0 to 1.0.5 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3046 - chore(deps): bump actions/checkout from 3.1.0 to 4.1.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3044 - chore(deps): bump golang from `fd78f2f` to `fd78f2f` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3042 - chore(deps): bump ubi8/ubi-minimal from `d8b81a3` to `2882390` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3041 - chore(deps): bump alpine from `13b7e62` to `51b6726` in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3040 - chore(deps): bump golang from `04cf306` to `c4b696f` in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3038 - chore(deps): bump mkdocs-material from 9.5.3 to 9.5.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3043 - chore(deps): bump ossf/scorecard-action from 2.1.2 to 2.3.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3045 - docs: add security response process by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3037 - Fix wrong namespaceSelector configuration in snippet in document by [@kyasbal](https://togithub.com/kyasbal) in [external-secrets/external-secrets#3054 - chore: refactor/centralise secretKeyRef usage by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3022 - chore: fixup security response suggestions by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3056 - feat: allow provider to return admission warnings by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3058 - chore(deps): bump alpine from 3.18 to 3.19 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3039 - chore: add tests for AWS/SM by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3057 - chore(deps): bump mkdocs-minify-plugin from 0.5.0 to 0.7.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3063 - chore(deps): bump markupsafe from 2.1.3 to 2.1.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3062 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3065 - added metrics support for akeyless by [@charan986](https://togithub.com/charan986) in [external-secrets/external-secrets#3069 - chore: bump jwx pkg by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3075 - IBM provider: remove deprecated code for fetching secret by name by [@Shanti-G](https://togithub.com/Shanti-G) in [external-secrets/external-secrets#3078 - chore(deps): bump codecov/codecov-action from 3.1.4 to 3.1.5 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3090 - chore(deps): bump golang from `fd78f2f` to `a6a7f1f` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3086 - chore(deps): bump alpine from `51b6726` to `c5b1261` in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3088 - chore(deps): bump github/codeql-action from 3.23.1 to 3.23.2 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3089 - chore(deps): bump golang from `c4b696f` to `d8c365d` in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3084 - chore(deps): bump alpine from `51b6726` to `c5b1261` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3087 - 🧹 refactor vault provider by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3072 - chore: bump ubi image by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3096 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3091 - chore(deps): bump alpine from 3.19.0 to 3.19.1 in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3083 - chore(deps): bump codecov/codecov-action from 3.1.5 to 4.0.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3104 - chore(deps): bump github/codeql-action from 3.23.2 to 3.24.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3103 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3113 - chore(deps): bump peter-evans/slash-command-dispatch from 3.0.2 to 4.0.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3102 - Feat/ready condition early by [@ppatel1604](https://togithub.com/ppatel1604) in [external-secrets/external-secrets#3077 - chore(deps): bump mkdocs-material from 9.5.4 to 9.5.7 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3106 - chore(deps): bump platformdirs from 4.1.0 to 4.2.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3105 - chore(deps): bump markupsafe from 2.1.4 to 2.1.5 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3107 - chore(deps): bump urllib3 from 2.1.0 to 2.2.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3109 - chore(deps): bump mkdocs-minify-plugin from 0.7.2 to 0.8.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3108 #### New Contributors - [@Tycale](https://togithub.com/Tycale) made their first contribution in [external-secrets/external-secrets#2986 - [@Aransh](https://togithub.com/Aransh) made their first contribution in [external-secrets/external-secrets#2985 - [@A1994SC](https://togithub.com/A1994SC) made their first contribution in [external-secrets/external-secrets#2881 - [@matusf](https://togithub.com/matusf) made their first contribution in [external-secrets/external-secrets#2998 - [@bthuilot](https://togithub.com/bthuilot) made their first contribution in [external-secrets/external-secrets#2646 - [@rpasche](https://togithub.com/rpasche) made their first contribution in [external-secrets/external-secrets#3007 - [@barucoh](https://togithub.com/barucoh) made their first contribution in [external-secrets/external-secrets#3013 - [@aslafy-z](https://togithub.com/aslafy-z) made their first contribution in [external-secrets/external-secrets#3021 - [@fdberlking](https://togithub.com/fdberlking) made their first contribution in [external-secrets/external-secrets#3010 - [@charlesthomas](https://togithub.com/charlesthomas) made their first contribution in [external-secrets/external-secrets#2971 - [@aviadkray](https://togithub.com/aviadkray) made their first contribution in [external-secrets/external-secrets#2991 - [@PeterStolz](https://togithub.com/PeterStolz) made their first contribution in [external-secrets/external-secrets#3023 - [@Mehrbod2002](https://togithub.com/Mehrbod2002) made their first contribution in [external-secrets/external-secrets#3003 - [@M0NsTeRRR](https://togithub.com/M0NsTeRRR) made their first contribution in [external-secrets/external-secrets#2869 - [@rodrigorfk](https://togithub.com/rodrigorfk) made their first contribution in [external-secrets/external-secrets#3018 - [@kyasbal](https://togithub.com/kyasbal) made their first contribution in [external-secrets/external-secrets#3054 **Full Changelog**: external-secrets/external-secrets@v0.9.11...v0.9.12 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://togithub.com/external-secrets/external-secrets) | patch | `0.9.11` -> `0.9.12` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.9.12`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.9.12) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.9.11...v0.9.12) Image: `ghcr.io/external-secrets/external-secrets:v0.9.12` Image: `ghcr.io/external-secrets/external-secrets:v0.9.12-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.12-ubi-boringssl` #### What's Changed - bump 0.9.11 by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#2982 - chore(deps): bump golang from 1.20.1 to 1.21.5 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#2976 - fix: chart: update cert-manager cert. duration by [@Tycale](https://togithub.com/Tycale) in [external-secrets/external-secrets#2986 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#2988 - Fix value name by [@Aransh](https://togithub.com/Aransh) in [external-secrets/external-secrets#2985 - feat: add ability to define flavour for tag by [@A1994SC](https://togithub.com/A1994SC) in [external-secrets/external-secrets#2881 - Fix typo in pushsecrets docs by [@matusf](https://togithub.com/matusf) in [external-secrets/external-secrets#2998 - feat: add PushSecret and DeleteSecret to onepassword provider by [@bthuilot](https://togithub.com/bthuilot) in [external-secrets/external-secrets#2646 - Configure codecov by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#2995 - added some example for v2 literal templating by [@rpasche](https://togithub.com/rpasche) in [external-secrets/external-secrets#3007 - Akeyless Provider - Add support for Certificate items by [@barucoh](https://togithub.com/barucoh) in [external-secrets/external-secrets#3013 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3005 - Feat/allow keeper to work with complex types by [@ppodevlabs](https://togithub.com/ppodevlabs) in [external-secrets/external-secrets#3016 - docs: update controller reconcile error rule by [@aslafy-z](https://togithub.com/aslafy-z) in [external-secrets/external-secrets#3021 - Issue/2965 - Documentation does not reflect latest changes for datafrom for IBM Secret Manager by [@fdberlking](https://togithub.com/fdberlking) in [external-secrets/external-secrets#3010 - doc: update bitwarden-cli image & version by [@charlesthomas](https://togithub.com/charlesthomas) in [external-secrets/external-secrets#2971 - Update the ExternalSecret status even when data is empty by [@shuheiktgw](https://togithub.com/shuheiktgw) in [external-secrets/external-secrets#2927 - grammar - it is by [@aviadkray](https://togithub.com/aviadkray) in [external-secrets/external-secrets#2991 - gramar2 - intuitive not intuative by [@aviadkray](https://togithub.com/aviadkray) in [external-secrets/external-secrets#2992 - docs: add command to install CRDs using kustomize by [@PeterStolz](https://togithub.com/PeterStolz) in [external-secrets/external-secrets#3023 - Validator by [@Mehrbod2002](https://togithub.com/Mehrbod2002) in [external-secrets/external-secrets#3003 - chore(deps): bump golang from 1.21.5 to 1.21.6 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3024 - feat: set default namespace on vault secretStore (namespaced ressource) by [@M0NsTeRRR](https://togithub.com/M0NsTeRRR) in [external-secrets/external-secrets#2869 - Create OSSF scorecard job by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3032 - feat: add support for Hashicorp Vault mTLS by [@rodrigorfk](https://togithub.com/rodrigorfk) in [external-secrets/external-secrets#3018 - \[Snyk] Fix for 5 vulnerabilities by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3036 - chore(deps): bump tornado from 6.3.3 to 6.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3051 - chore(deps): bump click from 8.1.3 to 8.1.7 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3050 - chore(deps): bump actions/cache from 3.3.3 to 4.0.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3049 - chore(deps): bump github/codeql-action from 2.2.4 to 3.23.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3048 - chore(deps): bump markupsafe from 2.1.1 to 2.1.3 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3047 - chore(deps): bump mkdocs-macros-plugin from 0.7.0 to 1.0.5 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3046 - chore(deps): bump actions/checkout from 3.1.0 to 4.1.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3044 - chore(deps): bump golang from `fd78f2f` to `fd78f2f` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3042 - chore(deps): bump ubi8/ubi-minimal from `d8b81a3` to `2882390` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3041 - chore(deps): bump alpine from `13b7e62` to `51b6726` in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3040 - chore(deps): bump golang from `04cf306` to `c4b696f` in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3038 - chore(deps): bump mkdocs-material from 9.5.3 to 9.5.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3043 - chore(deps): bump ossf/scorecard-action from 2.1.2 to 2.3.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3045 - docs: add security response process by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3037 - Fix wrong namespaceSelector configuration in snippet in document by [@kyasbal](https://togithub.com/kyasbal) in [external-secrets/external-secrets#3054 - chore: refactor/centralise secretKeyRef usage by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3022 - chore: fixup security response suggestions by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3056 - feat: allow provider to return admission warnings by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3058 - chore(deps): bump alpine from 3.18 to 3.19 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3039 - chore: add tests for AWS/SM by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3057 - chore(deps): bump mkdocs-minify-plugin from 0.5.0 to 0.7.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3063 - chore(deps): bump markupsafe from 2.1.3 to 2.1.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3062 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3065 - added metrics support for akeyless by [@charan986](https://togithub.com/charan986) in [external-secrets/external-secrets#3069 - chore: bump jwx pkg by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3075 - IBM provider: remove deprecated code for fetching secret by name by [@Shanti-G](https://togithub.com/Shanti-G) in [external-secrets/external-secrets#3078 - chore(deps): bump codecov/codecov-action from 3.1.4 to 3.1.5 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3090 - chore(deps): bump golang from `fd78f2f` to `a6a7f1f` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3086 - chore(deps): bump alpine from `51b6726` to `c5b1261` in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3088 - chore(deps): bump github/codeql-action from 3.23.1 to 3.23.2 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3089 - chore(deps): bump golang from `c4b696f` to `d8c365d` in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3084 - chore(deps): bump alpine from `51b6726` to `c5b1261` by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3087 - 🧹 refactor vault provider by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3072 - chore: bump ubi image by [@moolen](https://togithub.com/moolen) in [external-secrets/external-secrets#3096 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3091 - chore(deps): bump alpine from 3.19.0 to 3.19.1 in /e2e by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3083 - chore(deps): bump codecov/codecov-action from 3.1.5 to 4.0.1 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3104 - chore(deps): bump github/codeql-action from 3.23.2 to 3.24.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3103 - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [external-secrets/external-secrets#3113 - chore(deps): bump peter-evans/slash-command-dispatch from 3.0.2 to 4.0.0 by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3102 - Feat/ready condition early by [@ppatel1604](https://togithub.com/ppatel1604) in [external-secrets/external-secrets#3077 - chore(deps): bump mkdocs-material from 9.5.4 to 9.5.7 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3106 - chore(deps): bump platformdirs from 4.1.0 to 4.2.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3105 - chore(deps): bump markupsafe from 2.1.4 to 2.1.5 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3107 - chore(deps): bump urllib3 from 2.1.0 to 2.2.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3109 - chore(deps): bump mkdocs-minify-plugin from 0.7.2 to 0.8.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [external-secrets/external-secrets#3108 #### New Contributors - [@Tycale](https://togithub.com/Tycale) made their first contribution in [external-secrets/external-secrets#2986 - [@Aransh](https://togithub.com/Aransh) made their first contribution in [external-secrets/external-secrets#2985 - [@A1994SC](https://togithub.com/A1994SC) made their first contribution in [external-secrets/external-secrets#2881 - [@matusf](https://togithub.com/matusf) made their first contribution in [external-secrets/external-secrets#2998 - [@bthuilot](https://togithub.com/bthuilot) made their first contribution in [external-secrets/external-secrets#2646 - [@rpasche](https://togithub.com/rpasche) made their first contribution in [external-secrets/external-secrets#3007 - [@barucoh](https://togithub.com/barucoh) made their first contribution in [external-secrets/external-secrets#3013 - [@aslafy-z](https://togithub.com/aslafy-z) made their first contribution in [external-secrets/external-secrets#3021 - [@fdberlking](https://togithub.com/fdberlking) made their first contribution in [external-secrets/external-secrets#3010 - [@charlesthomas](https://togithub.com/charlesthomas) made their first contribution in [external-secrets/external-secrets#2971 - [@aviadkray](https://togithub.com/aviadkray) made their first contribution in [external-secrets/external-secrets#2991 - [@PeterStolz](https://togithub.com/PeterStolz) made their first contribution in [external-secrets/external-secrets#3023 - [@Mehrbod2002](https://togithub.com/Mehrbod2002) made their first contribution in [external-secrets/external-secrets#3003 - [@M0NsTeRRR](https://togithub.com/M0NsTeRRR) made their first contribution in [external-secrets/external-secrets#2869 - [@rodrigorfk](https://togithub.com/rodrigorfk) made their first contribution in [external-secrets/external-secrets#3018 - [@kyasbal](https://togithub.com/kyasbal) made their first contribution in [external-secrets/external-secrets#3054 **Full Changelog**: external-secrets/external-secrets@v0.9.11...v0.9.12 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>

bthuilot requested a review from a team as a code owner August 23, 2023 21:15

bthuilot requested review from gusfcarvalho and removed request for a team August 23, 2023 21:15

paul-the-alien bot reviewed Aug 23, 2023

View reviewed changes

bthuilot force-pushed the onepassword-secret-push branch from 1ac19e2 to 7de029e Compare August 23, 2023 21:50

bthuilot mentioned this pull request Aug 24, 2023

onepassword PushSecret functionality #2565

Closed

feat: add PushSecret and DeleteSecret to onepassword provider

7c2e5e8

Signed-off-by: Bryce Thuilot <bryce@thuilot.io>

bthuilot force-pushed the onepassword-secret-push branch from e061f92 to 7c2e5e8 Compare November 10, 2023 19:32

onedr0p mentioned this pull request Dec 19, 2023

Add PushSecret config for Ceph RGW buckets for Thanos onedr0p/home-ops#6605

Closed