Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for redgifs.com #508

Closed
Zenivo opened this issue May 10, 2020 · 7 comments
Closed

Please add support for redgifs.com #508

Zenivo opened this issue May 10, 2020 · 7 comments

Comments

@Zenivo
Copy link

Zenivo commented May 10, 2020

Gfycat NSFW content has migrated to redgifs.com, but this is not supported by the plugin.

@Eiion
Copy link
Contributor

Eiion commented May 11, 2020

Came here to suggest the same, considering regifs.com being the new place for basically every nsfw content that previously would have been posted on the very popular gfycat.com. "redgifs" is gfycat's own website to post nsfw content.

@extesy extesy closed this as completed in 935b5df May 14, 2020
@Eiion
Copy link
Contributor

Eiion commented May 14, 2020

@extesy You've closed the issue and it seems that you've added the plugin. I've tried something similar locally but that didn't work.
Not sure if I'm on the newest version yet (I'm on 1.0.143) since the extension isn't listed on the store anymore (https://chrome.google.com/webstore/detail/pccckmaobkjjboncdfnnofkonhgpceea only gives me a 404 error) - but it's certainly not working for me right now.

Any info on why the extension went missing from the store?

@extesy
Copy link
Owner

extesy commented May 14, 2020

@Eiion Please look at #512.

@Eiion
Copy link
Contributor

Eiion commented May 14, 2020

Oh dear... 🙄
Ok. I've replied to that other post making a hopeful suggestion.
But, for now, what would I have to do to add the plugin manually? I can create a script in the extensions folder and add the plugin by hand, but would that be all? When playing around with this before the plugin did not show up on the options page of the extension... are there other files that need to be modified for the plugin to show up in the options menu? (I honestly don't need it on the option's plugins page - but assuming this is needed for it to work is why I'm asking.)

EDIT: I've manually made all the changes listed on 935b5df (i.e. I've added the line to manifest.json at the same place where it should be and I've created the redgifs.js with those 18 lines of code). After restarting the browser the plugin doesn't show up on the options page of the extension though and it also doesn't work when hovering over a redgifs link on reddit.
Did I miss something?

EDIT 2: I've deactivated the original extension and loaded in the extracted download from github in dev mode. Wen't back to reddit and now everything works - including the new plugin. No idea what I did wrong before when doing the changes to the original extension manually.

@Eiion
Copy link
Contributor

Eiion commented May 19, 2020

@extesy Since the extension is back in the store I went back to that version (instead of the manually installed one via dev mode). Unfortunately in the store's version redgifs is (still?) not working. Is that still the pre-update pre-store-issues version or has there been plugins removed?

EDIT: Switched off the officially published version from the store and on the dev version - still redgifs isn't working. Now I'm confused... it is a version higher than the store version (which answers the previous question) and the plugin is listed on the options page, but even after restarting the browser it still isn't working when it was working perfectly fine until this last night.

EDIT2: I've kept trying and it turns out that some gifs hosted on redgifs work while others don't. I can't see a difference in how they're linked on reddit.
Though a change (unrelated) that I've noticed a few weeks back was that was that gifs now seem to be pre-cached before playing starts while before they started playing almost instantaneously. Is there a way to change it back to instant play?

@Eiion
Copy link
Contributor

Eiion commented May 21, 2020

@extesy I saw that you've made a change, applied it manually but that didn't help. I've once again got the current zip, unpacked and installed via dev mode - again, the plugin is still not working. While before it worked for some, now it actually works for none of the gifs hosted on redgifs that I could find on reddit.
I wonder if redgifs themselves keep changing things causing the plugin to not work or if there's another reason for why it first worked with all links, then with only some and now with none.

Addendum: I've just noticed that even some gfycat links don't work anymore. Reinstalled the extension in dev mode several times, as I did with re-starting Chrome - the issue still persists.

@Eiion
Copy link
Contributor

Eiion commented May 21, 2020

Today I've come across a post where - after clicking on the gfycat link in the reddit app - I landed on "gifdeliverynetwork.com" where the gif hat a watermark saying "REDGIFS This GIF is hosted by RedGIFs"

It appears to me that gfycat is messing around with how they host the content and moved on to pushing the NSFW gifs to "gifdeliverynetwork" instead of to redgifs... no idea what's going on with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants