Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EXTISM_PROFILE environment variable to configure profiling #326

Merged
merged 1 commit into from
May 18, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Apr 27, 2023

This could also be extended to support other wasmtime-based profiling methods, for now just perf is supported.

@nilslice
Copy link
Member

Let's add this to the docs somewhere too! Would be a cool thing to demo somehow on the docs site.

@zshipko zshipko marked this pull request as draft April 27, 2023 23:05
@bhelx bhelx marked this pull request as ready for review May 18, 2023 15:38
@bhelx
Copy link
Contributor

bhelx commented May 18, 2023

We're gonna merge this as it shouldn't cause any harm unless enabled. We can come back to it with additional changes for the next release if we need to.

@bhelx bhelx merged commit 0c70be2 into main May 18, 2023
@bhelx bhelx deleted the enable-perf branch May 18, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants