Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid timeout errors outside of extism_plugin_call #407

Merged
merged 6 commits into from
Aug 4, 2023
Merged

fix: avoid timeout errors outside of extism_plugin_call #407

merged 6 commits into from
Aug 4, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Aug 4, 2023 •
edited
Loading

  • Delays instantiation to right before a call by using instantiate_pre instead. This fixes an issue with the assemblyscript PDK.
  • Makes timeouts only apply to calls
  • Also bumps the wasmtime lower-bounds to 10.0, because the return type of the epoch callback has changed

bhelx
bhelx approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. by the time we ship this i think people should have time to upgrade to wasmtime 10.

@zshipko zshipko merged commit 07623ef into main Aug 4, 2023
32 checks passed
@zshipko zshipko deleted the delay-instantiation branch August 4, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zshipko @bhelx