Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not create or replace 'key_config.ron' #946

Closed
merikan opened this issue Oct 14, 2021 · 2 comments · Fixed by #1001
Closed

do not create or replace 'key_config.ron' #946

merikan opened this issue Oct 14, 2021 · 2 comments · Fixed by #1001
Labels
enhancement New feature or request
Milestone

Comments

@merikan
Copy link

merikan commented Oct 14, 2021

Is your feature request related to a problem? Please describe.
gitui creates the configuration file (~/.config/gitui/key_config.ron) when executed the first time.
If you decide to do some changes to this file to hold your own key-mappings then if an error is found or a key is missing this file is overwritten with new information. Since I have all my config files in git (dotfiles) and the file is just a symlink it will break.

Describe the solution you'd like

  1. don't create a file.
  2. if a file is found, the file contains only the remaps that the user wants, everything else should be as default
  3. If an error is found, ignore the error and show a small error footer in the ui.

Describe alternatives you've considered
If, for some reason, gitui still wants to create the configuration file when executed for the first time. Then a user-created file with the name key_config_user.ron could be used to override some or all settings.

Additional context

thanks for a great project 👍

@extrawurst extrawurst added the enhancement New feature or request label Oct 23, 2021
@extrawurst
Copy link
Owner

so I used this approach now as a POC for the new feature of allowing the user to customise the key symbol strings: #465

we can use the same approach for this here

@extrawurst
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants