Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ratatui #2157

Closed
wants to merge 2 commits into from
Closed

Conversation

nuke-web3
Copy link

@nuke-web3 nuke-web3 commented Mar 25, 2024

With ba26a1a I was unable to get cargo install --path . to work, with errors around ratatui. This PR updates deps such that resolution is happy & install is possible without --locked set for local installs at least.

This is a proper (I hope) fix for #2090 🤞

It changes the following:

  • cargo update
  • Update app to use ratatui 0.26.1 so only one version used in lock file.

Help requested:

make check yields a test fail that I think is a "me" problem with some python requirements missing on my machine:

---- tests::test_pre_commit_py stdout ----
[2024-03-25T23:38:45Z TRACE git2_hooks::hookspath] run hook '"/tmp/.tmpAYKxoe/.git/hooks/pre-commit"' in '"/tmp/.tmpAYKxoe/"'
thread 'tests::test_pre_commit_py' panicked at git2-hooks/src/lib.rs:473:9:
assertion failed: res.is_ok()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Might CI or a maintainer check if it is just me? 😅 - happy to try and fix it with your help if not.

I followed the checklist:

@nuke-web3
Copy link
Author

https://github.com/NukeManDan/gitui/commits/tmp/ shows I can indeed sign a gpg commit from a yubikey 🎉 suuuuuper excited this is working now!

@extrawurst
Copy link
Owner

extrawurst commented Mar 26, 2024

please see #2079 and #2100

right now this won't pass CI, you can simlate locally by running make check

@nuke-web3 nuke-web3 closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants