add vc runtime to wix / msi package #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooks crashing
|
@pm100 thanks for working on this. I merge this now and will ask for someone second with a windows machine to verify this works |
extrawurst
pushed a commit
that referenced
this pull request
May 27, 2021
* fix hook panicking (#393) * add vc merge module to msi Co-authored-by: Stephan Dilly <dilly.stephan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer run
cargo wix init.This is because we need to hand edit the main.wxs file that init creates. So instead this is now checked inThe vc redist binary msm is checked in too (it is not directly downloadable from MS, only as part of VC install)