Make gh-emoji optional

[jirutka]

gh-emoji crate includes images of GitHub's emoji - this is quite big dependency. It increases the binary size by 1 MiB; that's +25 % when building v0.18.0 on Alpine Linux with build flags to optimize size. I consider it an unnecessary bloat that should be optional.

Note: I’m maintainer of Alpine Linux’s gitui package (APKBUILD).

[extrawurst]

Good observation! Thanks for the contribution!

[jirutka]

The Security audit job is misleading, the reported issue is not related to the changes I made:

Error: Unable to publish audit check! Reason: HttpError: Resource not accessible by integration

[jirutka]

I’m now thinking that it may be better to name this feature ghemoji instead of just emoji? I originally wanted to name it gh-emoji, but Cargo confuses it with name of a crate in the dependencies.

[features]
gh-emoji=["gh-emoji"]

[extrawurst]

I’m now thinking that it may be better to name this feature ghemoji instead of just emoji? I originally wanted to name it gh-emoji, but Cargo confuses it with name of a crate in the dependencies.

[features]
gh-emoji=["gh-emoji"]

yeah I think ghemoji is more descriptive 👍

[jirutka]

yeah I think ghemoji is more descriptive +1

Okay, changed and rebased against master.