Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS support #778

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

tvOS support #778

wants to merge 6 commits into from

Conversation

rhaining
Copy link

inspired by @fassko! this PR is similar to #287, but based off of a recent fork of the master branch.

it provides tvOS support for the Macaw library. i've tested it with basic svg rendering, and it seems fine? the unit tests all pass, for what it's worth.

@cl0ter
Copy link

cl0ter commented Oct 27, 2021

Suppose tvOS platform missed in Package.swift. Anyway lgtm. Good job!

@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plist file name "Macaw copy-Info.plist"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 fixed!

@rhaining rhaining requested a review from cl0ter January 31, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants