Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement access control #13

Merged
merged 1 commit into from
May 14, 2022
Merged

Implement access control #13

merged 1 commit into from
May 14, 2022

Conversation

omg-xtao
Copy link
Contributor

You can set the ACCESS_KEY in config.json inside plugins/GCAuth to enable access control.

@exzork
Copy link
Owner

exzork commented May 14, 2022

so this access key thing is used for resetting password right?

@omg-xtao
Copy link
Contributor Author

You cannot register, login, or change your password unless you have the access key.

@exzork
Copy link
Owner

exzork commented May 14, 2022

You cannot register, login, or change your password unless you have the access key.

you sure we need this feature? I think i'll never use this one tho

@omg-xtao
Copy link
Contributor Author

You cannot register, login, or change your password unless you have the access key.

you sure we need this feature? I think i'll never use this one tho

It is an optional security feature that prevents anyone from registering private servers.

@exzork
Copy link
Owner

exzork commented May 14, 2022

but when you use like gc-tools / grassclipper user can see the request anyway, so i don't think it can prevent people from flooding register endpoint

@omg-xtao
Copy link
Contributor Author

but when you use like gc-tools / grassclipper user can see the request anyway, so i don't think it can prevent people from flooding register endpoint

Yes, only private servers need this feature.

Even if someone else knows the server address, he can't register, login, or change password.

@exzork
Copy link
Owner

exzork commented May 14, 2022

Okay, ig i'll merge it

@exzork exzork merged commit 0c0373a into exzork:main May 14, 2022
@omg-xtao omg-xtao deleted the password branch May 15, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants