Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak: Allocation without release in cuda::memory::virtual::set_access_mode #450

Closed
eyalroz opened this issue Jan 14, 2023 · 0 comments
Closed

Memory leak: Allocation without release in cuda::memory::virtual::set_access_mode #450

eyalroz opened this issue Jan 14, 2023 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Jan 14, 2023

In cuda::memory::virtual::set_access_mode(), we were allocating:

auto descriptors = new CUmemAccessDesc[devices.size()];

... without releasing. Instead, let's use an std::unique_ptr.
@eyalroz eyalroz added the bug label Jan 14, 2023
@eyalroz eyalroz self-assigned this Jan 14, 2023
eyalroz added a commit that referenced this issue Jan 14, 2023
@eyalroz
Fixes #450: Avoiding memory leak in `cuda::memory::virtual::set_acces…
3c6fdf4 
…s_mode()`

* Now using an `std::unique_ptr` rather than a raw `new`.
eyalroz added a commit that referenced this issue Jan 14, 2023
@eyalroz
Fixes #450: Avoiding memory leak in `cuda::memory::virtual::set_acces…
b0c4d5a 
…s_mode()`

* Now using an `std::unique_ptr` rather than a raw `new`.
eyalroz added a commit that referenced this issue Jan 14, 2023
@eyalroz
Fixes #450: Avoiding memory leak in `cuda::memory::virtual::set_acces…
e07329d 
…s_mode()`

* Now using an `std::unique_ptr` rather than a raw `new`.
eyalroz added a commit that referenced this issue Feb 10, 2023
@eyalroz
Fixes #450: Avoiding memory leak in `cuda::memory::virtual::set_acces…
004bcdd 
…s_mode()`

* Now using an `std::unique_ptr` rather than a raw `new`.
eyalroz added a commit that referenced this issue Mar 9, 2023
@eyalroz
Fixes #450: Avoiding memory leak in `cuda::memory::virtual::set_acces…
1bf87fc 
…s_mode()`

* Now using an `std::unique_ptr` rather than a raw `new`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz