Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a context-wrapper scoped-context-override when unnecessary #520

Closed
eyalroz opened this issue May 19, 2023 · 0 comments
Closed

Comments

@eyalroz
Copy link
Owner

eyalroz commented May 19, 2023

We have both cuda::context::current::scoped_override_t and cuda::context::current::detail_scoped_override_t . We mostly use the latter in API function implementations, but - in some places we use the former. Why? Actually, no good reason. The way we construct them, this could trigger additional actions - e.g. primary context pushing; but we don't actually need that to happen. So, let's be uniform again.

@eyalroz eyalroz added the task label May 19, 2023
@eyalroz eyalroz self-assigned this May 19, 2023
eyalroz added a commit that referenced this issue May 20, 2023
… we can just use the context-handle-based scoped override
eyalroz added a commit that referenced this issue Jun 7, 2023
… we can just use the context-handle-based scoped override

* Also, removing (now?-)redundant forward-declaration of `context::current::scoped_override_t`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant