Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the way we set WINDOWS_EXPORT_ALL_SYMBOLS #557

Closed
eyalroz opened this issue Dec 19, 2023 · 0 comments
Closed

Fix the way we set WINDOWS_EXPORT_ALL_SYMBOLS #557

eyalroz opened this issue Dec 19, 2023 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Dec 19, 2023

We should WINDOWS_EXPORT_ALL_SYMBOLS for individual targets, not at directory scope.

Morever, we can set it for any platform and compiler, so no need for the check for WIN32 and MSVC.
@eyalroz eyalroz added the task label Dec 19, 2023
@eyalroz eyalroz self-assigned this Dec 19, 2023
eyalroz pushed a commit that referenced this issue Dec 19, 2023
Fixes #557: Now WINDOWS_EXPORT_ALL_SYMBOLS just for our targets; an…
ae7bf4e 
…d without conditioning on WIN32+MSVC
@eyalroz eyalroz closed this as completed in a3572fc Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz