Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuda::memory::managed::region_t is not a useful definition, stick to cuda::memory::region_t #592

Closed
eyalroz opened this issue Feb 26, 2024 · 0 comments
Closed

cuda::memory::managed::region_t is not a useful definition, stick to cuda::memory::region_t #592

eyalroz opened this issue Feb 26, 2024 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 26, 2024

The managed region is not very useful, and is after all just a discriminated alias... let's drop it.
@eyalroz eyalroz added the task label Feb 26, 2024
@eyalroz eyalroz self-assigned this Feb 26, 2024
eyalroz added a commit that referenced this issue Feb 26, 2024
@eyalroz
Fixes #592: Drop memory::managed::region_t in favor of using just `…
22fbe25 
…memory::region_t`.
eyalroz added a commit that referenced this issue Feb 26, 2024
@eyalroz
Fixes #592: Drop memory::managed::region_t in favor of using just `…
0d59fde 
…memory::region_t`.
eyalroz added a commit that referenced this issue Feb 29, 2024
@eyalroz
Fixes #592: Drop memory::managed::region_t in favor of using just `…
ed95953 
…memory::region_t`.
@eyalroz eyalroz closed this as completed in 6821b2a Mar 1, 2024
eyalroz added a commit that referenced this issue Apr 20, 2024
@eyalroz
Fixes #592: Rework memory::managed::region_t and its relation to `m…
af83910 
…emory::region_t`.
eyalroz added a commit that referenced this issue Apr 29, 2024
@eyalroz
Regards #592: Changed approach to the relation of `memory::managed::r…
c9536bb 
…egion_t` to `memory::region_t`:

Now, `managed::region_t` inherits the general `region_t` rather than just the base class, and the same goes for `managed::const_region_t`; this is achieved using a different templated base class (within the `detail_` namespace)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz