Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support long double values #171

Open
eyalroz opened this issue Nov 24, 2023 · 1 comment
Open

Support long double values #171

eyalroz opened this issue Nov 24, 2023 · 1 comment
Labels
task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Nov 24, 2023

We currently don't support long double floating-point values - neither in terms of the printf syntax (%Lf is rejected), nor in terms of the semantics (we never va_arg(args, long double)).

As some platforms, and compilers, actually support long doubles - we should do so as well. At first, at least with lower-precision printing by casting to a double, but then preferably printing proper long doubles.
@eyalroz eyalroz added the task label Nov 24, 2023
eyalroz pushed a commit that referenced this issue Dec 9, 2023
@lygstate @eyalroz
Fixes #171: Adds support for long double format specifier and long do…
9e247c1 
…uble input arguments - but _not_ for internal processing of long doubles, they are down-converted to the internal representation type. Tweaked some comment text and removv ed some redundant testcases involving float-promotion relative to Yonggag Luo's original commit.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
@eyalroz eyalroz added the resolved-on-develop A changeset fixing this issue has been commiutted to the development branch label Dec 9, 2023
eyalroz pushed a commit that referenced this issue Dec 9, 2023
@lygstate @eyalroz
Regards #171: Adds support for long double format specifier and long …
835a48b 
…double input arguments - but _not_ for internal processing of long doubles, they are down-converted to the internal representation type. Tweaked some comment text and removv ed some redundant testcases involving float-promotion relative to Yonggag Luo's original commit.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
@eyalroz eyalroz removed the resolved-on-develop A changeset fixing this issue has been commiutted to the development branch label Dec 9, 2023
@eyalroz
Copy link
Owner Author

eyalroz commented Dec 9, 2023

So, the syntax is now supported. The harder party is actually processing long doubles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz