Fix Autoloader (i.e. failed requires) - Read before file a bug report for failed requires! #49

eyecatchup · 2013-11-05T15:44:10Z

LAST EDITED 2013-12-16

Okay. First, there were some cross-platform path name seperator issues ("" instead of "/"), which resulted in many users experienced failed requires. On the other hand, there were some composer users having issues with my custom PSR-0 Autoloader class.

Because these issues existed for some time and I still had no time to fix it myself, I merged #41 and #42. These commits (thanks to @francisbesset) fix both issues by using the PHP constant DIRECTORY_SEPARATOR as a path name seperator and replacing the custom Autoloader class by composer's.

However, this breaks autoloading without composer for the current master branch. I will merge back the custom PSR-0 Autoloader class for alternative use with the upcoming 2.5.3 release.

If you have issues with failed requires, for the moment the best way is to use composer to install SEOstats (as referenced here). The alternative way, downloading the Zip-File from Github does not work! If there's no way for you to work with composer, you can still download the Zip-File of the Dev-Version of 2.5.3 here: https://github.com/eyecatchup/SEOstats/archive/dev-253.zip . This still includes the "old" custom Autoloader class for you to use the examples out of the box. However, you need to change the back slashes ("") - used in the example files to require the autoloader class - with the DIRECTORY_SEPARATOR constant (see this comment for more detailed instructions).

The text was updated successfully, but these errors were encountered:

florentcm · 2013-11-14T21:07:47Z

Is the composer supposed to create the Autoload.php file in Common directory during installation ?

drvipinlalt · 2013-11-25T13:15:06Z

I got an error, i don't find autoload.php anywhere

Link is http://pagerank.co.in/seostats/example/get-alexa-graphs.php

Warning: require_once(/home3/shopkera/public_html/www.pagerank.co.in/seostats/example/../vendor/autoload.php) [function.require-once]: failed to open stream: No such file or directory in /home3/shopkera/public_html/www.pagerank.co.in/seostats/example/get-alexa-graphs.php on line 13

Fatal error: require_once() [function.require]: Failed opening required '/home3/shopkera/public_html/www.pagerank.co.in/seostats/example/../vendor/autoload.php' (include_path='.:/opt/php53/lib/php') in /home3/shopkera/public_html/www.pagerank.co.in/seostats/example/get-alexa-graphs.php on line 13

eyecatchup · 2013-12-03T22:26:00Z

@knotnow

Is the composer supposed to create the Autoload.php file in Common directory during installation ?

Nope, it's not. Composer creates an autoload.php in ./vendor/autoload.php - relative to the path where you run the install command. This autoloader is actually just a stub to ./vendor/composer/autoload_real.php, which finally includes and registers the custom class map and namespace(s) and in turn makes the old Common/AutoLoader.php (that would live in ./vendor/seostats/seostats/SEOstats/Common/AutoLoader.php now) obsolete.

Just include composer's autoloader and you're ready to go. Checkout the following:

As you can see, the example files are still working almost out of the box when placed in composer's SEOstats install path. There was just a wrong require path to composer's ./vendor/autoload.php in the example files (hey, it wasn't me ;)).

C:\xampp\htdocs\seostats-master-20131203>diff get-google-pagerank.php vendor\seostats\seostats\example\get-google-pagerank.php
13c13
< require_once __DIR__ . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php';
---
> require_once __DIR__.DIRECTORY_SEPARATOR.'..'.DIRECTORY_SEPARATOR.'vendor'.DIRECTORY_SEPARATOR.'autoload.php';

I'll push a change to fix the wrong paths in a few minutes.

eyecatchup · 2013-12-03T22:51:30Z

@drvipinlalt

I got an error, i don't find autoload.php anywhere
Failed opening required '/home3/shopkera/public_html/www.pagerank.co.in/seostats/example/../vendor/autoload.php'

Well, looking at the paths, you did obviously not installed SEOstats via composer, correct? But http://pagerank.co.in/seostats/composer.json shows that you use the current master branch code (version 2.5.2).

Quote from the first post in this thread: "The alternative way, downloading the Zip-File from Github does not work!"

I'm sorry if I wasn't clear enough, but you must install SEOstats via composer right now. Or, use the Dev-Version of 2.5.3 here: https://github.com/eyecatchup/SEOstats/archive/dev-253.zip

eyecatchup · 2013-12-04T00:32:06Z

Fix commited. Also added some more info to the example files for those who download the master zip.

halbesma · 2013-12-16T07:52:03Z

Can someone please explain in a bit more detail what this means: "However, you may need to change the forward slashes ("") with the DIRECTORY_SEPARATOR constant."

eyecatchup · 2013-12-16T17:19:47Z

@halbesma

Can someone please explain in a bit more detail what this means: "However, you may need to change the forward slashes ("\") with the DIRECTORY_SEPARATOR constant."

Well, first of there's a small mistake - it should read backslash.. Anyway, I was trying to say the following:

Even though the Zip-File of the Dev-Version of 2.5.3 (https://github.com/eyecatchup/SEOstats/archive/dev-253.zip) contains the custom Autoloader class (which is missing in the current master branch), you still need to change the path separators.

The example files (in 2.5.3) contain the following line to specify the path to the bootstrap.php file:

// Bootstrap the library / register autoloader
require_once (__DIR__ . '\..') . '\SEOstats\bootstrap.php';

Backslashes work fine on Windows systems, but don't work on *nix. So, unless you work on a Windows machine, you'll need to change these back slashes ("") to forward slashes ("/"):

// Bootstrap the library / register autoloader
require_once (__DIR__ . '/..') . '/SEOstats/bootstrap.php';

Or - even better - replace the backslashes with PHP's DIRECTORY_SEPARATOR constant (that way it is cross-platform safe):

// Bootstrap the library / register autoloader
require_once (__DIR__ . DIRECTORY_SEPARATOR . '..') . DIRECTORY_SEPARATOR . 'SEOstats' . DIRECTORY_SEPARATOR . 'bootstrap.php';

halbesma · 2013-12-16T20:35:25Z

@eyecatchup

Made the changes to the examples as per your post. However I get a 500 error. In the error log it gave me the following:

[16-Dec-2013 15:29:57 America/New_York] PHP Fatal error: Class 'SEOstats\SEOstats' not found in /home/dpuqsevb/public_html/domain/seo/example/get-alexa-graphs.php on line 21

I changed change this line in Autoloader.php:

protected $namespace = '';

to

protected $namespace = '\';

Then I got the following 500 error:

[16-Dec-2013 15:41:10 America/New_York] PHP Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ',' or ';' in /home/dpuqsevb/public_html/domain/seo/SEOstats/Common/AutoLoader.php on line 33

I changed all the ' to " in autoloader.php (except for line 18 and 23).
I then get this error:

PHP Parse error: syntax error, unexpected T_NS_SEPARATOR, expecting ',' or ';' in /home/dpuqsevb/public_html/domain/seo/SEOstats/Common/AutoLoader.php on line 23

It refers to this line:

protected $path = '';

eyecatchup · 2013-12-16T21:14:50Z

@halbesma thanks for the detailed feedback. checking.. what's your os, server & php version?

halbesma · 2013-12-16T21:19:01Z

@eyecatchup
Linux and PHP 5.3.27
Cheers

Also had the same error using another Linux server with PHP 5.4.22

eyecatchup · 2013-12-17T00:22:03Z

With the changes I made today, I can now install SEOstats via composer or use the zip download of the master branch again. All I need to do is to place the example files in the install directory and, in case of the zip download method, adjust the include path (as described in the example files). Both methods (composer and direct download) have been tested by and worked fine for me, on the following systems:

Windows 7 / Apache 2.2 (Xampp) stack running PHP 5.4.7
Ubuntu 12.04 / Apache 2.4 stack running 5.5.3
Debian Squeeze / Nginx 1.4.4 stack running PHP 5.3.10-1~dotdeb.0 (with Suhosin-Patch)
Debian Squeeze / Nginx 1.4.4 stack running PHP 5.3.27-1~dotdeb.0 (with Suhosin-Patch)

@halbesma I can not reproduce your error. Can you please help me and follow these steps:

Download the most recent zip from master branch
Extract the zip to /some-path/seostats
Copy
/some-path/seostats/example/get-alexa-metrics.php to
/some-path/seostats/get-alexa-metrics.php and
/some-path/seostats/example/get-google-pagerank.php to
/some-path/seostats/get-google-pagerank.php
Open the example files and change the autoload include (see inline comment)
Run example files

If that does not work (and you still get the error that you described upthread), please try one more thing:

Save this file in /some-path/seostats/SEOstats/Common/SplClassLoader.php
Open your /some-path/seostats/SEOstats/bootstrap.php and change (and save) it as follows:

/*
 *---------------------------------------------------------------
 *  Register custom PSR-0 Autoloader
 *---------------------------------------------------------------
 */

#require_once realpath(__DIR__ . '/Common/AutoLoader.php');
require_once realpath(__DIR__ . '/Common/SplClassLoader.php');

#$autoloader = new \SEOstats\Common\AutoLoader(__NAMESPACE__, dirname(__DIR__));
$autoloader = new \SEOstats\Common\SplClassLoader(__NAMESPACE__, dirname(__DIR__));

$autoloader->register();

Got it working?

halbesma · 2013-12-17T17:20:00Z

@eyecatchup
Most examples work as per your first instructions using the zip download method with the exception of the following errors:

Fatal error: Class 'SEOstats\Services\SEMRush' not found in /home/domainqu/public_html/SEOstats/get-semrush-graphs.php on line 28

and

Fatal error: Class 'SEOstats\Services\SEMRush' not found in /home/domainqu/public_html/SEOstats/get-semrush-metrics.php on line 28

Other than that, all is working perfectly!
Cheers!

eyecatchup · 2013-12-17T17:50:58Z

@halbesma Thanks again. Glad to hear it's working for you now.

Yep, that's why I asked for get-google-pagerank.php and get-alexa-metrics.php specifically - I tested only these 2 yesterday. Checking on the SEMRush classes later and commit a fix for it asap too.

microthemes · 2014-01-04T22:37:02Z

@halbesma

I'm also facing this issue:

Fatal error: Class 'SEOstats\Services\SEMRush' not found in ...

When I'm trying to use @eyecatchup SplClassLoader.php
it's return:

Warning: require(../SEOstats/Services/SEMRush.php): failed to open stream: No such file or directory in ...

So the quick solution is rename SemRush.php to SEMRush.php, I got it work! see http://domainstatistic.info?q=example.com

Rifki

Evan-R · 2014-02-04T11:04:50Z

the bootstrap is not necessary if you just register a reasonable autoloader for modules in your application, something like this:

function __autoload_namespaced_module($class) {
    $path = str_replace('\\', '/', $class);

    if (file_exists($file = (PATH_TO_MODULES_DIR . $path . '.php'))) {
        require_once($file);
    }
}

spl_autoload_register();
spl_autoload_register('__autoload_namespaced_module');

ClemensSahs · 2014-02-17T10:12:55Z

He guy

It looks for me that this is a problem with the different write of "SemRush.php" and "SEMRush"

On Windows everything ok and Linux don't work this different version. The reason the windows filesystem interpret the UpCase as DownCase, too. For linux are "SemRush.php" and "SEMRush.php" tow different files...

Solution 1: rename the file name
Solution 2: rename the class name

ClemensSahs · 2014-05-09T14:15:27Z

We fix this with the commit right? so this can close?

ClemensSahs · 2014-08-27T07:32:21Z

I will close this issue now. If any one can reproduce this with the current beta (2.5.3-beta4) we can open this again

ghost assigned eyecatchup Nov 5, 2013

This was referenced Nov 5, 2013

PHP Fatal error: require_once(): Failed opening #46

Closed

Incomplete composer install with error #38

Closed

Use DIRECTORY_SEPARATOR for all path names #36

Closed

eyecatchup mentioned this issue Dec 3, 2013

Wrong path reference to composer's autoload.php in example files #55

Closed

eyecatchup mentioned this issue Dec 16, 2013

Help with installation without Composer #60

Closed

ClemensSahs added 2 - Working and removed 2 - Working labels Aug 4, 2014

ClemensSahs closed this as completed Aug 27, 2014

ClemensSahs removed the 3 - Done label Aug 27, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Autoloader (i.e. failed requires) - Read before file a bug report for failed requires! #49

Fix Autoloader (i.e. failed requires) - Read before file a bug report for failed requires! #49

eyecatchup commented Nov 5, 2013

florentcm commented Nov 14, 2013

drvipinlalt commented Nov 25, 2013

eyecatchup commented Dec 3, 2013

eyecatchup commented Dec 3, 2013

eyecatchup commented Dec 4, 2013

halbesma commented Dec 16, 2013

eyecatchup commented Dec 16, 2013

halbesma commented Dec 16, 2013

eyecatchup commented Dec 16, 2013

halbesma commented Dec 16, 2013

eyecatchup commented Dec 17, 2013

halbesma commented Dec 17, 2013

eyecatchup commented Dec 17, 2013

microthemes commented Jan 4, 2014

Evan-R commented Feb 4, 2014

ClemensSahs commented Feb 17, 2014

ClemensSahs commented May 9, 2014

ClemensSahs commented Aug 27, 2014

Fix Autoloader (i.e. failed requires) - Read before file a bug report for failed requires! #49

Fix Autoloader (i.e. failed requires) - Read before file a bug report for failed requires! #49

Comments

eyecatchup commented Nov 5, 2013

florentcm commented Nov 14, 2013

drvipinlalt commented Nov 25, 2013

eyecatchup commented Dec 3, 2013

eyecatchup commented Dec 3, 2013

eyecatchup commented Dec 4, 2013

halbesma commented Dec 16, 2013

eyecatchup commented Dec 16, 2013

halbesma commented Dec 16, 2013

eyecatchup commented Dec 16, 2013

halbesma commented Dec 16, 2013

eyecatchup commented Dec 17, 2013

halbesma commented Dec 17, 2013

eyecatchup commented Dec 17, 2013

microthemes commented Jan 4, 2014

Evan-R commented Feb 4, 2014

ClemensSahs commented Feb 17, 2014

ClemensSahs commented May 9, 2014

ClemensSahs commented Aug 27, 2014