feat(rule): email #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #17 +/- ##
==========================================
+ Coverage 94.23% 94.48% +0.24%
==========================================
Files 5 5
Lines 538 562 +24
==========================================
+ Hits 507 531 +24
Misses 31 31 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## devel #17 +/- ##
==========================================
+ Coverage 94.23% 94.48% +0.24%
==========================================
Files 5 5
Lines 538 562 +24
==========================================
+ Hits 507 531 +24
Misses 31 31 |
Idered
reviewed
Aug 22, 2017
src/validators.js
Outdated
| @@ -106,3 +106,11 @@ export function validateRegex(attribute, value, parameters) { | |||
|
|
|||
| return regex ? regex.test(value) : true | |||
| } | |||
|
|
|||
| export function validateEmail(attribute, value) { | |||
| if (is.not.string(value) && is.not.number(value)) { | |||
There was a problem hiding this comment.
return is.email(value) should be enough, isn't it?
There was a problem hiding this comment.
No, for example ['daniel@ss.com'] passes even if array is not a valid email
Idered
approved these changes
Aug 22, 2017
…into validator#Email # Conflicts: # src/messages.js # src/validators.js
Codecov Report
@@ Coverage Diff @@
## devel #17 +/- ##
==========================================
- Coverage 94.56% 94.48% -0.08%
==========================================
Files 5 5
Lines 570 562 -8
==========================================
- Hits 539 531 -8
Misses 31 31 |
Codecov Report
@@ Coverage Diff @@
## devel #17 +/- ##
==========================================
+ Coverage 94.56% 94.78% +0.21%
==========================================
Files 5 5
Lines 570 594 +24
==========================================
+ Hits 539 563 +24
Misses 31 31 |
Codecov Report
@@ Coverage Diff @@
## devel #17 +/- ##
==========================================
+ Coverage 94.56% 94.78% +0.21%
==========================================
Files 5 5
Lines 570 594 +24
==========================================
+ Hits 539 563 +24
Misses 31 31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.