-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ergonomics: Hide context
behind a feature
#131
Comments
I've noticed this as well, it'll falsely import the wronf trait. I've found the same with Maybe it is better to put all those aliases under a feature, and only expose |
I also experience the Fully agree with your proposal. |
SGTM, I have no objections to any of the suggested changes. |
I can handle any questions or reviewing that comes up later for you @LeoniePhiline |
This change hides the `anyhow` compatibility layer behind an `"anyhow"` feature flag. In `eyre` v0.6 the feature is enabled by default. Fixes eyre-rs#131
This change hides the `anyhow` compatibility layer behind an `"anyhow"` feature flag. In `eyre` v0.6 the feature is enabled by default. Fixes eyre-rs#131
This change hides the `anyhow` compatibility layer behind an `"anyhow"` feature flag. In `eyre` v0.6 the feature is enabled by default. Fixes eyre-rs#131
This change hides the `anyhow` compatibility layer behind an `"anyhow"` feature flag. In `eyre` v0.6 the feature is enabled by default. Fixes eyre-rs#131
This change hides the `anyhow` compatibility layer behind an `"anyhow"` feature flag. In `eyre` v1.0.0 the feature is currently enabled by default. Fixes #131 --------- Co-authored-by: Freja Roberts <ten3roberts@gmail.com>
[eyre-rs#131][131] introduced a new anyhow default feature flag to allow users to hide aliased exports such as `eyre::Error` and `eyre::Context`. This changeset removes `anyhow` from the list of default features, making the compatibility layer with the anyhow crate opt-in. Implements [eyre-rs#136][136] [131]: eyre-rs#131 [136]: eyre-rs#136 BREAKING CHANGE: Removing a default feature is a breaking change.
[eyre-rs#131][131] introduced a new anyhow default feature flag to allow users to hide aliased exports such as `eyre::Error` and `eyre::Context`. This changeset removes `anyhow` from the list of default features, making the compatibility layer with the anyhow crate opt-in. Implements [eyre-rs#136][136] [131]: eyre-rs#131 [136]: eyre-rs#136 BREAKING CHANGE: Removing a default feature is a breaking change.
When using
eyre
day by day, rust analyzer often proposes to import theContext
trait, whenWrapErr
functions likewrap_err_with
are not imported.(Rust analyzer does not even offer importing
WrapErr
, but onlyContext
. I do not know why.)As I do not need
anyhow
compatibility, I would prefermod context
to be feature gated.The text was updated successfully, but these errors were encountered: