OptionExt feature test is incorrectly feature-gated behind the anyhow flag
#147
Comments
LeoniePhiline
added a commit
to LeoniePhiline/eyre
that referenced
this issue
Jan 24, 2024
thenorili
pushed a commit
to LeoniePhiline/eyre
that referenced
this issue
Feb 29, 2024
ten3roberts
pushed a commit
that referenced
this issue
Mar 14, 2024
# 1. Clarify trait usage in location test [`8522f02`](8522f02) Both `WrapErr` and `ContextCompat` expose `anyhow` compatibility methods. - `ContextCompat` is completely feature gated behind the `anyhow` flag. - `WrapErr`, on the other hand, feature-gates individual functions behind the `anyhow` flag. This has led to [confusion][confusion] in the past. This change moves the `use eyre::WrapErr` statement from the top of the module into each individual test, as [identically named functions](#149) (`wrap_err.*`) are exposed both by `WrapErr` and `ContextCompat`. With `use eyre::WrapErr` moved directly into the tests, it becomes clear which trait-provided `fn` is being called. [confusion]: #138 (comment) # 2. Remove `anyhow` feature flag from `OptionExt` location test [`68744f1`](68744f1) This bug was introduced (by me) in 34bd1d9#diff-1ff47dac6cf55e34ff587968c5b1f1ec6b6ae39d2668a66ecba3633163a21fc5R86 - partly due to the confusion fixed with the above commit. Fixes #147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Introduced at 34bd1d9#diff-1ff47dac6cf55e34ff587968c5b1f1ec6b6ae39d2668a66ecba3633163a21fc5R86
The text was updated successfully, but these errors were encountered: