Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eyre code into a folder #107

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Move eyre code into a folder #107

merged 1 commit into from
Oct 3, 2023

Conversation

pksunkara
Copy link
Contributor

No description provided.

@ten3roberts
Copy link
Contributor

Should the license files be at the top level, and used for most of our crates, or be one per crate?

Most of our crates use the same license, so it'd be useful to merge them together at the top level.

@yaahc what do you think?

@pksunkara
Copy link
Contributor Author

That's what I did. If you see the diff, I haven't changed them but added symlinks to inside the eyre folder.

@ten3roberts
Copy link
Contributor

Oh I see, didn't catch that they were symlinks, it is not usually I see them in git

@yaahc
Copy link
Collaborator

yaahc commented Oct 3, 2023

Should the license files be at the top level, and used for most of our crates, or be one per crate?

Most of our crates use the same license, so it'd be useful to merge them together at the top level.

@yaahc what do you think?

I don't see any issue with either version, tho I'm not someone who pays particularly close attention to licensing and legal concerns. I figure if there's an issue someone will open an issue to let us know and we can fix it then.

@yaahc yaahc merged commit a443fd4 into master Oct 3, 2023
29 checks passed
@yaahc yaahc deleted the eyre branch October 3, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants