fix: ok_or_eyre not using track_caller
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, good catch! |
thenorili
force-pushed
the
fix-ok-or-eyre
branch
from
c9a6cee
to
7d98ac3
Compare
thenorili
approved these changes
Dec 30, 2023
ten3roberts
pushed a commit
that referenced
this pull request
Mar 14, 2024
Fix tests and warnings from new compiler versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ok_or_eyredid not usetrack_caller, which meant the error location was incorrect compared to the equivalent anyhow::context feature