chore: Use run instead of predict_and_parse #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all your efforts very much appreciated! I'll try to merge on Monday! |
|
Sorry took a while -- was trying to figure out whether to use call method vs. run method and type mismatches on the run method. Code looks good! Thanks! |
eyurtsev
approved these changes
Jul 11, 2023
| @@ -0,0 +1,33 @@ | |||
| from langchain.chat_models import ChatOpenAI | |||
There was a problem hiding this comment.
Any objections if I re-write as a unit test instead of an integration test? I think a mock response from open AI will work well for this test case?
There was a problem hiding this comment.
No objections, feed free to re-write the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #185
This PR set the KorParser as the OutputParser on the LLMChain. This is needed, since
predict_and_parseon the LLMChain is deprecated andrunshould be used. For this minimum LangChain version is raised to 0.0.205.This PR includes