-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from users lib to uzers #150
Conversation
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
@cafkafk Since it's the same with |
Also added uzers to the advisory database so |
Maybe you'd want it in the eza-community org? If you wanna maintain it from your account that's also fine imo, just thought I should mention the option in case. Either way, a maintained version is definitely preferred. |
I actually thought about that, but since I'm not in the maintainers list, I wasn't able to create a repo here. Since I already commented the new url in all the issues the advisory DB created in other repos, moving would mean changing all those again and that could create some confusion ... so I think it's easier to keep it how it is for now. But for the |
On organization roles
I looked into permissions for doing this, and I can only give "repository roles" via teams on a repository level, not organizationally. There are only two types of organizational roles: There is a feature to add more, but it's paid :( The best I can do in the free tier seems to be enabling all organization members to create public repositories, which I have just done. On team rolesI'm gonna think about the best way to structure repository permissions and then redo these very soon! I think it makes sense to give out more permissions to you and @PThorpe92, so you can triage and do stuff like assign labels, or assigning yourself to issues etc, which I just realized today you couldn't! Tell me if there is something you can't do that you should be able to do. |
Signed-off-by: Sandro-Alessio Gierens <sandro@gierens.de>
I'm a little mystified as to why GitHub recognizes the intended change in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing of code indicates it's working, moving from an unmaintained library to a maintained fork is a pretty easy conclusion. TY, merging! (after CI)
So, I ran
cargo audit
on eza and it warns thatusers
(https://github.com/ogham/rust-users) is unmaintained, which makes sense since this is how eza came about :D ... So I thought since theuutils
fellows are working on aterm-grid
fork, I would be good if all our other deps are also clean and maintained. So I forkedrust-users
to https://github.com/gierens/uzers-rs, reviewed and merged the existing pull requests, added CI workflows, cleaned up a bit, and published it to https://crates.io/crates/uzers .This migrates the
users
dependency to saiduzers
.