-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding new icons #554
base: main
Are you sure you want to change the base?
Conversation
Thanks for making the changes easy to see, and for adding the tests.. Personally I like near enough all of those changes. Icons are certainly a matter of preference so we'll see what the rest of the maintainers think, but I like it 👍 |
Since src, build, and test are different,So I used different icons for them. |
@cfxegbert |
We use the wrench icon to represent files such as Makefile that build other files and not for testing. |
92246ae
to
6176773
Compare
6176773
to
9683862
Compare
67d0319
to
b7c3ee8
Compare
Suggested by @hasecilu |
Could you do me a favor and add for I forgot this in a previous PR and don't want to open a new one just for one icon. |
|
Yes I am well aware.. We already have for |
@cfxegbert any changes ? |
@cafkafk @cfxegbert, any changes ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the conflicts, then I'll take another look :)
941dbfe
to
f2c34fb
Compare
Done 👍 |
@cafkafk ? |
Changed icons
CONFIG
frome615
to
f107b
f107b
shows it is a file (config file).FILE_OUTLINE
fromf016
to
f086f
question mark makes easy to identify it is a unknown file (no file extension).
GIT
fromf1d3
to
f02a2
f1d3
showgit
in the icon ,f02a2
shows thelogo
in icon.OLD
NEW
New Folder icons