Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(time_display): use /etc/timezone for time display #715

Closed
wants to merge 3 commits into from

Conversation

erwinvaneijk
Copy link
Contributor

When a file timestamp is updated under daylight saving time, and displayed when it is not, the wrong time offset is displayed (and vice versa).

Fixes issue #653 .

When a file timestamp is updated under daylight saving time, and
displayed when it is not, the wrong time offset is displayed (and vice
versa).

Fixes issue eza-community#653.
@erwinvaneijk erwinvaneijk changed the title feat(time display): use /etc/timezone for time display feat(time_display): use /etc/timezone for time display Dec 9, 2023
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you have a commit that's not following https://www.conventionalcommits.org/en/v1.0.0/, you'll have to change the commit summary to conform first so the check passes.

@cafkafk
Copy link
Member

cafkafk commented Dec 12, 2023

I should mention the issue likely is the spacing in the scope (time display)

@erwinvaneijk
Copy link
Contributor Author

I should mention the issue likely is the spacing in the scope (time display)

Thank you, that helps. I'll see how I can change that commit message.

When a file timestamp is updated under daylight saving time, and
displayed when it is not, the wrong time offset is displayed (and vice
versa).

Fixes issue eza-community#653.
@erwinvaneijk erwinvaneijk deleted the issue-653 branch December 12, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants