Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exa PR) 1199: Added icons for .rmeta and .ino files #8

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented Jul 29, 2023

@cafkafk cafkafk changed the title (exa PR) 1199 (exa PR) 1199: Added icons for .rmeta and .ino files Jul 29, 2023
@cafkafk
Copy link
Member Author

cafkafk commented Jul 29, 2023

Cargo tests are all okay.

I don't have the icons font needed.

Testing requested
  • cargo test
  • touch test.rmeta test.ino
  • cargo run --release -- --icons
  • post screenshot of output

@cafkafk cafkafk added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers looking for testers features › icon and removed enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers looking for testers labels Jul 29, 2023
@@ -205,6 +205,7 @@ pub fn icon_for_file(file: &File<'_>) -> char {
"html" => '\u{f13b}', // 
"hxx" => '\u{f0fd}', // 
"ico" => '\u{f1c5}', // 
"ino" => '\u{e61d}', // 
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this

Co-authored-by: Tobias Clasen <sandalbanditten@tutanota.com>
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
@cafkafk cafkafk merged commit 40ed085 into main Jul 30, 2023
8 checks passed
@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks
@cafkafk cafkafk deleted the pr-1199 branch July 30, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants