This repository has been archived by the owner on Aug 9, 2020. It is now read-only.
Add frontend settings page for configuration file extension #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezaquarii
reviewed
Oct 17, 2019
| NavigationBar | ||
| } | ||
| }) | ||
| export default class ConfigFileExtensionSettings extends Vue { |
There was a problem hiding this comment.
I'd prefer to have a General settings page, where more misc options can be added in the future. Having a page
per option will probably not look very good.
ezaquarii
reviewed
Oct 17, 2019
| email_enabled = models.BooleanField(default=False) | ||
| registration_enabled = models.BooleanField(default=True) | ||
| config_file_extension = models.CharField(choices=FILE_EXTENSION_CHOICES, |
There was a problem hiding this comment.
I think we'd need 2 options: one for the client (which mostly expects ovpn), one for server (which mostly requires conf file, as this is what systemd on Linux expects).
I'd then default to ovpn on the client and conf for the server.
|
Stale draft. Please re-open if you wish to continue working on this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ #11