-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EZP-21585: set correct col. length for oracle #19
base: master
Are you sure you want to change the base?
Conversation
Note: now when we use ColumnTypeTranslation in dbschema.ini.append.php, the max length for varchar cols has to be set to 1000. |
In ref to the other issues with the "hack". To be clear, @gggeek, your fix is clearly better. A bit of a shame it came What bothers me a bit is that ezoracle is no longer actively developped. It And while it is better from a technical pov, I'm not sure of what to think |
Indeed it poses a bit of a challenge:
|
The update SQL script is missing otherwise the upgrade check won't like it. |
Well, my idea was that customers could actually use the upgrade-check exactly to get the sql generated for them which would set the schema to the new version. |
you can not just send the customers to the upgrade check to get the SQL, if for instance they have a custom table, it will suggest to remove it. |
Nitpick: suggestion for custom tables to be removed only happens if extensions do not implement the proper .dba table definition as per the standard. I know that a lot of user-extensions (and sadly even some eZ-ones) do not respect that standard, so I agree that we can not just uphold it blindly. As for table list: no it is not known, as this change applies to all tables, including ones from extensions - the only way to do the change in pure sql would be via a PL-SQL program |
The tables from our extensions that need to be fixed should be identified and the corresponding setting should then be added to dbschema.ini.append.php otherwise the upgrade check will report a warning. |
… semantics, to allow for UTF8. While at it, set the length for all BLOBS we shorten to 4k instead of arbitrary 3000 or 3100
Added update script - as PLSQL procedure. As for other extensions, I used an advanced search on github (https://github.com/search?q=ColumnTypeTranslation+%40ezsystems+extension%3Aphp&type=Code&ref=advsearch&l=PHP) |
I detail: properly declare all oracle columns lengths using CHAR semantics, to allow for UTF8.
While at it, set the length for all BLOBS we shorten to 4k instead of arbitrary 3000 or 3100
Meant to replace both #18 and ezsystems/ezpublish-legacy#811