Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32294: Location removal removes all children silently and unreversable #1707

Merged
merged 2 commits into from
Feb 18, 2021
Merged

EZP-32294: Location removal removes all children silently and unreversable #1707

merged 2 commits into from
Feb 18, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Feb 15, 2021 •
edited
Loading

Question Answer
Tickets EZP-32294
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

JIRA excerpt:

When removing a location of an object, all child nodes will be removed, too. This happens silently and without going to the trash.

The frontend (CSS) part relates to modals' content: when the text is too long, it overflows the modal. This remark applies only to 2.5 so this change will be dropped on merge-up.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@konradoboza konradoboza self-assigned this Feb 16, 2021
@konradoboza konradoboza marked this pull request as ready for review February 16, 2021 08:33
dabrt
dabrt requested changes Feb 16, 2021
View reviewed changes
Copy link

@dabrt dabrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the messages.

src/bundle/Resources/translations/locationview.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/translations/locationview.en.xliff Outdated Show resolved Hide resolved
src/bundle/Resources/views/content/tab/locations/tab.html.twig Outdated Show resolved Hide resolved
@konradoboza
Copy link
Member Author

konradoboza commented Feb 16, 2021 •
edited
Loading

@dabrt are you fine with messages in the current shape?

@konradoboza konradoboza removed their assignment Feb 16, 2021
@bogusez bogusez self-assigned this Feb 17, 2021
@lserwatka lserwatka merged commit 63b4335 into 1.5 Feb 18, 2021
@lserwatka lserwatka deleted the ezp-32294-location-children-removed-silently branch February 18, 2021 07:18
@konradoboza
Copy link
Member Author

Merged up to 2.2: 5906ab9
Merged up to master: bfd88d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabrt dabrt dabrt approved these changes

@bogusez bogusez bogusez approved these changes

@dew326 dew326 dew326 approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@DominikaK DominikaK Awaiting requested review from DominikaK

Assignees

@bogusez bogusez

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@konradoboza @alongosz @dew326 @bogusez @dabrt @lserwatka