Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-461: Fixed roles with deleted limitations #1781

Merged
merged 2 commits into from
Jun 17, 2021
Merged

IBX-461: Fixed roles with deleted limitations #1781

merged 2 commits into from
Jun 17, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jun 16, 2021

Question Answer
Tickets IBX-461
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Follow up PR of ezsystems/repository-forms#347.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Jun 16, 2021
@barw4 barw4 requested a review from a team June 16, 2021 13:22
Steveb-p
Steveb-p approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the general solution.

src/lib/Tests/Form/DataTransformer/UDWBasedValueViewTransformerTest.php Show resolved Hide resolved
@Steveb-p Steveb-p requested review from alongosz and a team June 16, 2021 15:23
@tomaszszopinski tomaszszopinski self-assigned this Jun 17, 2021
tomaszszopinski
tomaszszopinski approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa DXP 3.3.4 & 3.3.4-dev with diff & patch

@lserwatka lserwatka merged commit 6332d3e into 2.3 Jun 17, 2021
@lserwatka lserwatka deleted the ibx-461-fix-roles-with-deleted-limitations branch June 17, 2021 10:48
@lserwatka
Copy link
Member

You can merge it up

@barw4
Copy link
Member Author

barw4 commented Jun 17, 2021

Merged into master: c245fe1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@barw4 @lserwatka @adamwojs @Steveb-p @Nattfarinn @alongosz @tomaszszopinski