Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-375: Fixed setting 2nd menu level active #1830

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Jul 27, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-375
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

When working on IBX-375 we noticed there is a problem with 2nd level menu. Even though you set extras.routes on first level element and it matches, the second level menu won't be displayed unless there is a match on a child. In some cases you still want to display 2nd level menu, for example Page Builder submenu when there is no siteaccess match.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@webhdx webhdx requested review from a team July 27, 2021 11:53
@webhdx webhdx self-assigned this Jul 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micszo micszo self-assigned this Jul 27, 2021
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webhdx webhdx merged commit 6b304a3 into 1.5 Jul 30, 2021
@webhdx webhdx deleted the set_2nd_menu_level_active branch July 30, 2021 11:16
@micszo micszo removed their assignment Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants