Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1948: Log exceptions from admin-ui #2028

Merged
merged 1 commit into from
Feb 10, 2023
Merged

IBX-1948: Log exceptions from admin-ui #2028

merged 1 commit into from
Feb 10, 2023

Conversation

vidarl
Copy link
Member

@vidarl vidarl commented Jan 18, 2022 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1948
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vidarl vidarl requested a review from a team January 18, 2022 08:51
@adamwojs
Copy link
Member

@vidarl could you please address @Steveb-p feedback ?

@vidarl
Copy link
Member Author

vidarl commented Apr 22, 2022

Hi @adamwojs . Yes, sorry about the delay. I'll have a look next week

@vidarl
Copy link
Member Author

vidarl commented Apr 28, 2022

@vidarl could you please address @Steveb-p feedback ?

@adamwojs , I have done so, but I have some comments. Please see the unresolved threads.

@vidarl vidarl requested a review from Steveb-p April 28, 2022 09:14
@adamwojs adamwojs changed the title IBX-1948 : Log exceptions from admin-ui IBX-1948: Log exceptions from admin-ui Apr 28, 2022
@vidarl vidarl changed the base branch from 1.5 to 2.3 May 19, 2022 11:54
@vidarl vidarl force-pushed the IBX-1948_log_exceptions_from_admin-ui branch from 858ab7d to d202db0 Compare May 19, 2022 11:54
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davidsayre
Copy link

Hi, How do I get this commit into my DXP build? I really need the admin UI to log errors becuase it's very difficult to troubleshoot.
Please review this commit and if passed/ merge.

Steveb-p
Steveb-p reviewed Dec 15, 2022
View reviewed changes
src/lib/EventListener/AdminExceptionListener.php Outdated Show resolved Hide resolved
src/lib/EventListener/AdminExceptionListener.php Outdated Show resolved Hide resolved
src/bundle/Resources/config/services/events.yaml Outdated Show resolved Hide resolved
src/bundle/Resources/config/services/events.yaml Outdated Show resolved Hide resolved
@Steveb-p
Copy link
Contributor

Steveb-p commented Dec 15, 2022 •
edited
Loading

Hi, How do I get this commit into my DXP build? I really need the admin UI to log errors becuase it's very difficult to troubleshoot. Please review this commit and if passed/ merge.

@davidsayre Sorry, it kinda went under the radar.

As a workaround, you can create a service in your project, and make it listen to kernel.exception events, with priority higher than this listener (which is currently 0 priority, so at minimum 1). Then follow normal Symfony rules for injecting logger and log the error in the same fashion as is done here.

@vidarl vidarl requested a review from Steveb-p January 11, 2023 14:49
@vidarl
Copy link
Member Author

vidarl commented Jan 11, 2023

Everything is resolved. Ready for merge now ? @Steveb-p

@vidarl vidarl force-pushed the IBX-1948_log_exceptions_from_admin-ui branch from 11211da to 78d0ccf Compare January 12, 2023 09:34
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomaszszopinski tomaszszopinski self-assigned this Feb 9, 2023
tomaszszopinski
tomaszszopinski approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@Nattfarinn Nattfarinn merged commit aa7aa34 into 2.3 Feb 10, 2023
@Nattfarinn Nattfarinn deleted the IBX-1948_log_exceptions_from_admin-ui branch February 10, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@tomaszszopinski tomaszszopinski

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vidarl @adamwojs @davidsayre @Steveb-p @webhdx @ViniTou @tomaszszopinski @mikadamczyk @Nattfarinn