IBX-5076: Fixed disabling ability to copy subtree #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ViniTou
approved these changes
Feb 13, 2023
konradoboza
approved these changes
Feb 13, 2023
tests/bundle/DependencyInjection/Configuration/Parser/SubtreeOperationsTest.php
Show resolved
Hide resolved
micszo
approved these changes
Mar 28, 2023
alongosz
force-pushed
the
ibx-5076-emptyish-copy-subtree-limit
branch
from
1bcff6a
to
fa40517
Compare
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
alongosz
force-pushed
the
ibx-5076-emptyish-copy-subtree-limit
branch
from
fa40517
to
41f49d8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3+We checked emptiness of
subtree_operations.copy_subtree.limitcontextual setting which disallowed setting it to 0.Given this is till this day the only one setting for that Config Parser, I've simplified the code to reduce cognitive complexity which probably led to this error.
Checklist:
$ composer fix-cs).