Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4542: Implemented ImageAdditionalData type #130

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Dec 21, 2022

Question Answer
JIRA issue IBX-4542
Type improvement
Target Ibexa version v3.3
BC breaks no

Example query:

{
  media {
    image (id: 261) {
      id,
      name,
      image {
        id,
        fileName,
        fileSize,
        additionalData {
          focalPointX,
          focalPointY
        }
      }
    }
  }
}

@barw4 barw4 self-assigned this Dec 21, 2022
@barw4 barw4 requested a review from a team December 21, 2022 13:40
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested review from webhdx and a team December 21, 2022 13:43
@barw4 barw4 requested a review from bdunogier December 23, 2022 12:22
@barw4 barw4 requested a review from adamwojs January 2, 2023 16:33
@micszo micszo self-assigned this Jan 10, 2023
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine for me. 👍🏻

Tested on Ibexa Commerce 3.3.30-dev.

@micszo micszo removed their assignment Jan 11, 2023
@konradoboza konradoboza merged commit 3c1cc66 into 2.3 Jan 11, 2023
@konradoboza konradoboza deleted the ibx-4542-ImageAdditionalData-type branch January 11, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants