Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed EZP-32302: Kosovo and South Sudan are missing in the Country FieldType #163

Closed
wants to merge 1 commit into from

Conversation

konradoboza
Copy link
Member

Question Answer
JIRA issue EZP-32302
Type bug
Target eZ Platform version v3.2, v3.3
BC breaks no
Doc needed no

Excerpt from JIRA:

The customer observed that Kosovo is missing on Country FieldType. We should also add South Sudan and update Macedonia.

This PR target versions 3.2 and 3.3.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Jan 22, 2021
@konradoboza konradoboza self-assigned this Jan 22, 2021
@konradoboza
Copy link
Member Author

@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alongosz
Copy link
Member

@alongosz not sure whether this change should also be reflected in https://github.com/ezsystems/ezcommerce-base-design/blob/master/ezpublish_legacy/silver.content/settings/selections.ini.append.php.

No, looks like unused Legacy config and Legacy is past EOM.

Regardless, this needs to be handled as a horizontal merge from ezsystems/ezpublish-kernel#3082, not a PR. Feel free to use this branch as a reference, so I'm not going to delete it yet.

@alongosz alongosz closed this Jan 25, 2021
@konradoboza konradoboza deleted the EZP-32302-country-ft-kosovo branch January 28, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants