Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-3606: Removed duplicate siteaccess names #332

Merged
merged 1 commit into from
Aug 26, 2022
Merged

IBX-3606: Removed duplicate siteaccess names #332

merged 1 commit into from
Aug 26, 2022

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Aug 24, 2022 •
edited
Loading

Question Answer
JIRA issue IBX-3606
Type bug
Target Ibexa version v3.3
BC breaks no

Yaml configuration allows to add the same Site Access more than once resulting in :

    siteaccess:
        list: [admin, site, site]

This PR removes those duplicates in StaticSiteAccessProvider constructor.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@reithor reithor marked this pull request as ready for review August 24, 2022 14:11
@reithor reithor requested review from mikadamczyk and a team August 24, 2022 14:12
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@reithor reithor added the Bug Something isn't working label Aug 24, 2022
@adamwojs adamwojs changed the title IBX-3606: removed duplicate siteaccess names IBX-3606: Removed duplicate siteaccess names Aug 25, 2022
tomaszszopinski
tomaszszopinski approved these changes Aug 26, 2022
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@mikadamczyk mikadamczyk merged commit 96eb83e into 1.3 Aug 26, 2022
@mikadamczyk
Copy link
Contributor

@reithor could you merge it up to ibexa?

@mikadamczyk mikadamczyk deleted the ibx-3606_remove_duplicate_siteaccesses branch August 26, 2022 07:34
@reithor
Copy link
Contributor Author

reithor commented Aug 26, 2022

@mikadamczyk merged up to ibexa/4.1 and ibexa/main now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@ciastektk ciastektk ciastektk approved these changes

@damianz5 damianz5 damianz5 approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Bug Something isn't working QA approved Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.