IBX-4326: Custom URL aliases reparenting

[barw4]

Question	Answer
JIRA issue	IBX-4326
Type	bug
Target Ibexa version	v3.3
BC breaks	no

Custom aliases were not reparented previously and simply were breaking when a parent was moved.

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/engineering-team).

[adamwojs]

Good one.

[mnocon]

The tests are failing because of symfony/symfony#48832 , I've switched the selector to XPath in 2d04adf to make them green again

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[fancyweb]

@mnocon The behavior of CSS abbr[title='$exceptionString'] to XPath has not changed in the latest symfony/css-selector release. Can you explain the problem plz?

[mnocon]

@fancyweb thank you for asking!

Our usage looks like this:
https://github.com/ezsystems/ezplatform-kernel/blob/1.3/eZ/Bundle/EzPublishCoreBundle/Features/Exception/unauthorized_login_form.feature#L10-L11

         Then an eZ\Publish\Core\Base\Exceptions\UnauthorizedException is displayed
          And an Symfony\Component\Security\Core\Exception\AccessDeniedException is displayed

and the Step definition is here:
https://github.com/ezsystems/ezplatform-kernel/blob/1.3/eZ/Bundle/EzPublishCoreBundle/Features/Context/ExceptionContext.php#L59-L65

    /**
     * @Then /^(?:a|an) ([\w\\]+Exception) is displayed$/
     */
    public function anAccessDeniedExceptionIsThrown($exceptionString)
    {
        $this->assertSession()->elementExists('css', "abbr[title='$exceptionString']");
    }

So the actual CSS selector looked like this:

abbr[title='eZ\Publish\Core\Base\Exceptions\UnauthorizedException']

When running it locally I got the Unfinished literal error mentioned in symfony/symfony#48832 - and the tests were passing until last week, which made me think we've hit the same issue related to backslash escaping.

In our case I've switched to XPath, which seems to handle it without issues.

Please let me know if there's anything else that you'd like me to add here.