Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4700: Added versionNo argument for Content Proxy #357

Merged
merged 1 commit into from
Jan 11, 2023
Merged

IBX-4700: Added versionNo argument for Content Proxy #357

merged 1 commit into from
Jan 11, 2023

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jan 5, 2023

Question Answer
JIRA issue IBX-4700
Type improvement
Target Ibexa version v3.3
BC breaks no

As the title suggests.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 added Improvement Changes not fixing or changing behavior Ready for review labels Jan 5, 2023
@barw4 barw4 self-assigned this Jan 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@barw4 barw4 requested a review from a team January 6, 2023 10:34
konradoboza
konradoboza approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe @adamwojs remembers if this one was perhaps skipped intentionally when introduced via ezsystems/ezpublish-kernel#2844?

@konradoboza konradoboza requested a review from a team January 9, 2023 07:23
@barw4 barw4 requested a review from adamwojs January 9, 2023 10:03
@bogusez bogusez self-assigned this Jan 11, 2023
This was referenced Jan 11, 2023
Closed
Closed
Closed
@bogusez
Copy link

bogusez commented Jan 11, 2023

Regression tests passed for all builds:
ibexa/commerce#196
ibexa/experience#125
ibexa/content#67

@bogusez bogusez added QA approved Ready for MERGE To be set by author or maintainer and removed Ready for QA labels Jan 11, 2023
@adamwojs adamwojs merged commit 9862753 into 1.3 Jan 11, 2023
@adamwojs adamwojs deleted the ibx-4700-versionNo-content-proxy branch January 11, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@bogusez bogusez bogusez approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

@barw4 barw4

@bogusez bogusez

Labels
Improvement Changes not fixing or changing behavior QA approved Ready for MERGE To be set by author or maintainer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@barw4 @bogusez @adamwojs @ViniTou @konradoboza @mikadamczyk @Steveb-p @alongosz @ciastektk