Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-962: New custom tag inserting #205

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

SerheyDolgushev
Copy link
Contributor

@SerheyDolgushev SerheyDolgushev commented Sep 2, 2021

Question Answer
JIRA issue IBX-962
Bug/Improvement yes
New feature no
Target Ibexa version 3.3
BC breaks no
Tests pass yes
Doc needed no

Steps to reproduce:

  1. Create a new content item with RichText field
  2. Try to insert Facebook (or any other) custom tag into the RichText field
  3. On the custom tag attributes screen click the "Cancel" link

Expected result
Insert custom tag dialog is closed.

Actual result
Insert custom tag dialog stays on the screen and the following JavaScript error is thrown:

react-dom.production.min.js:32 Uncaught TypeError: Cannot read property 'setFocused' of null at ButtonCustomTagUpdate.cancelCustomTagEdit

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs added the Bug Something isn't working label Sep 2, 2021
@adamwojs
Copy link
Member

adamwojs commented Sep 2, 2021

CI failure is not related to PR changes

@bogusez bogusez self-assigned this Sep 3, 2021
@bogusez
Copy link

bogusez commented Sep 3, 2021

@SerheyDolgushev unfortunately but fix didn't solve the problem on my local environment. I've tried to apply the fix in both ways (clone repo using your fork and also patching the file).

@bogusez
Copy link

bogusez commented Sep 3, 2021

It seems like I had some problems with my local environment. After reinstalling local env, fix works fine. Sorry for confusion.

@lserwatka lserwatka merged commit 2d425e3 into ezsystems:2.3 Sep 3, 2021
@lserwatka
Copy link
Member

@alongosz could you merge it up?

@alongosz
Copy link
Member

alongosz commented Sep 3, 2021

Merged into master via 2c5df1a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Development

Successfully merging this pull request may close these issues.

9 participants