IBX-215: Added semantic configuration for password related views #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
requested review from
adamwojs,
mikadamczyk,
Steveb-p,
Nattfarinn,
alongosz,
webhdx and
juskora
adamwojs
reviewed
Apr 16, 2021
src/bundle/DependencyInjection/Configuration/Parser/ResetPassword.php
Outdated
Show resolved
Hide resolved
src/bundle/DependencyInjection/Configuration/Parser/ForgotPassword.php
Outdated
Show resolved
Hide resolved
| @@ -31,8 +31,8 @@ public function addSemanticConfig(NodeBuilder $nodeBuilder) | |||
| ->scalarNode('form') | |||
| ->info('Template to use for change password form rendering.') | |||
| ->end() | |||
| ->scalarNode('confirmation') | |||
| ->info('Template to use for change password confirmation rendering.') | |||
| ->scalarNode('success') | |||
There was a problem hiding this comment.
I would say this is not BC break as user_change_password.templates.confirmation parameter was never used ;)
Steveb-p
approved these changes
Apr 27, 2021
ciastektk
approved these changes
Apr 28, 2021
adamwojs
approved these changes
May 1, 2021
tomaszszopinski
approved these changes
May 5, 2021
|
Could you merge it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons unknown, some views were lacking proper semantic configuration and were only configurable thru whole parameter name.
Checklist:
$ composer fix-cs)