[Feat] 병합과정 문제 수정 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
applecv3
commented
Jul 21, 2021
applecv3
commented
- DB 컨벤션에 맞게 쿼리문 수정
- 임포트 경로 문제 수정
- api 형식 통일
1. DB 컨벤션에 맞게 쿼리문 수정 2. 임포트 경로 문제 수정 3. api 형식 통일
| @@ -113,7 +113,7 @@ public void changePassword(@RequestBody HashMap<String, String> passwords, HttpS | |||
| * 로그인된 상태에서 새 주소 추가 | |||
| * @param addressDto 새 주소가 들어있는 HashMap<String> | |||
| */ | |||
| @PostMapping("mypage/addaddress") | |||
| @PostMapping("/mypage/addaddress") | |||
There was a problem hiding this comment.
어차피 Post 방식으로 요청되는거 아니까 @PostMapping("/mypage/address")로 해도 되지 않을까요?
굳이 add를 넣을 필요는 없을 것 같아요.
kakao-gray-great
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.