This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[#9] refactor: signup service, and anything related #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
... MyBatis 쓰듯이 table을 구상했기 때문에, 엔티티 간 가져야 할 프로퍼티들에 대해서는 별도로 고민하지 못했음
ex. owner - restaurants, customer/rider - x
= 공통으로 받는 입력 값에 대해서는 중복된 메서드가 만들어진다.
= 이거를 어떻게 최소화 할 수 있을까
Done
= when (type)을 사용해 type에 따라 다른 repository, entity를 리턴하도록 할 수 있지 않을까?
= 안되더라....