Skip to content
This repository has been archived by the owner on Aug 13, 2022. It is now read-only.

#43 노선 삭제 #91

Merged
merged 3 commits into from
Sep 6, 2020
Merged

#43 노선 삭제 #91

merged 3 commits into from
Sep 6, 2020

Conversation

0hun
Copy link
Collaborator

@0hun 0hun commented Sep 4, 2020

노선 삭제 메소드 추가

노선 삭제 메소드 추가
@0hun 0hun requested a review from f-lab-dev September 4, 2020 15:30
@0hun 0hun self-assigned this Sep 4, 2020
Copy link
Member

@f-lab-dev f-lab-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 크리티컬한건 보이지 않네요. 리뷰드린 것 수정해주시고 머지하시면 될 것 같습니다~

* @return ResponseEntity
*/
@LoginCheck(userLevel = UserLevel.ADMIN)
@PatchMapping("/{id}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내부적인 관점에서는 업데이트지만 외부 사용자가 볼 때는 삭제입니다. DELETE가 더 의미에 맞지 않을까요??

@@ -54,7 +54,7 @@
, updated_at
FROM account
WHERE user_id = #{userId}
AND password = #{password}
AND password = #{password}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기는 오타로 보입니다~

외부 사용자가 볼떄는 삭제 메소드 이므로 DeleteMapping으로 수정
@0hun 0hun merged commit 11e7b5a into issue/42 Sep 6, 2020
@0hun 0hun deleted the issue/43 branch September 6, 2020 13:28
@0hun 0hun linked an issue Sep 9, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#43 노선 삭제
2 participants