Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : testAddCooperationAnd Rafectory #95

Closed
wants to merge 1 commit into from

Conversation

superkkj
Copy link
Contributor

관련된 이슈 번호

요약

  • 테스트 공통적으로 명시적 1L 사용대신 DUMY 로 쓸모없는 데이터라는걸 명시해주거나
  • 랜덤으로 Long값을 설정해 어떤 값이던간에 테스트를 통과하도록한다
  • 협력객체 조건을 추가하지않는 테스트를 추가해준다.

@superkkj superkkj linked an issue Nov 23, 2022 that may be closed by this pull request
@superkkj superkkj changed the title Fix : testAddCooperationAnd Rㅁfectory Fix : testAddCooperationAnd Rafectory Nov 23, 2022
@github-actions
Copy link

Unit Test Results

50 tests   - 2   50 ✔️  - 2   2s ⏱️ -1s
16 suites ±0     0 💤 ±0 
16 files   ±0     0 ±0 

Results for commit 00cba6b. ± Comparison against base commit 0e58b27.

This pull request removes 2 tests.
com.uniqueauction.domain.review.service.ReviewServiceTest ‑ 상품이 없을땐 NOTFOUND EXCEPTION
com.uniqueauction.domain.review.service.ReviewServiceTest ‑ 유저이 없을땐 NOTFOUND EXCEPTION

@superkkj superkkj self-assigned this Nov 23, 2022
@superkkj superkkj closed this Nov 23, 2022
@superkkj superkkj deleted the 94#bug-testAddCooperation branch November 23, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 테스트 부분 협력 객체까지 포함 리펙토링
1 participant