Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Function constuctor usage #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Function constuctor usage #49

wants to merge 1 commit into from

Conversation

jketcham
Copy link

@jketcham jketcham commented Oct 9, 2019

Addresses #48

@f
Copy link
Owner

f commented Oct 15, 2019

This does not actually solve the issue.

new Function("fragments", "return fragments.x.y.z")

is not equal to

fragments['x.y.z']

Thanks!

@f f closed this Oct 15, 2019
@f f reopened this Oct 15, 2019
@f
Copy link
Owner

f commented Oct 15, 2019

Oopss sorry. I re-read the code and seems like you're right! 😥 I'll merge it after my tests.

@jketcham
Copy link
Author

Awesome, thanks!

@urkle urkle mentioned this pull request Aug 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketcham @f