Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom backpressure support in favor of RxJava 1.1's built-in … #39

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Remove custom backpressure support in favor of RxJava 1.1's built-in … #39

merged 1 commit into from
Dec 9, 2015

Conversation

JakeWharton
Copy link
Contributor

…buffer latest.

@f2prateek
Copy link
Owner

LGTM!

Given that this is a built in RxJava operator now, does it even make sense for us to do it by default? Clients could easily opt in to this behaviour.

f2prateek added a commit that referenced this pull request Dec 9, 2015
Remove custom backpressure support in favor of RxJava 1.1's built-in …
@f2prateek f2prateek merged commit d012609 into f2prateek:master Dec 9, 2015
@JakeWharton
Copy link
Contributor Author

There's little benefit, I suppose. It's nice when backpressure Just Works™, but there is non-zero overhead (although it is very close to zero).

@JakeWharton
Copy link
Contributor Author

It can be advantageous to have backpressure supported higher up in the chain to avoid downstream work when it isn't needed (i.e., when back pressure is being applied). In this case we defer calling get() which will do value lookup and potential conversion. Very small win in this library's instance, but you can see how in other circumstances it's good to have higher up (e.g., if conversion needed to do a API call, for example).

@JakeWharton JakeWharton deleted the jw/backpressure branch December 9, 2015 18:50
@bryanstern bryanstern mentioned this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants