Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader alembic uv normal support #1069

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Reader alembic uv normal support #1069

merged 2 commits into from
Nov 21, 2023

Conversation

mwestphal
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (01565ff) 96.23% compared to head (a04c875) 96.28%.
Report is 2 commits behind head on master.

Files Patch % Lines
plugins/alembic/module/vtkF3DAlembicReader.cxx 99.36% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1069      +/-   ##
==========================================
+ Coverage   96.23%   96.28%   +0.05%     
==========================================
  Files         120      120              
  Lines        7031     7167     +136     
==========================================
+ Hits         6766     6901     +135     
- Misses        265      266       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal
Copy link
Contributor Author

@Meakk @nyue please review

@mwestphal mwestphal requested a review from Meakk November 16, 2023 07:10
@mwestphal mwestphal mentioned this pull request Nov 16, 2023
Closed
@mwestphal mwestphal force-pushed the reader_alembic_uv_normal_support branch 2 times, most recently from a05d71d to 5814df0 Compare November 18, 2023 21:24
Meakk
Meakk reviewed Nov 20, 2023
View reviewed changes
plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Show resolved Hide resolved
testing/baselines/TestABCFaceVarying.png Outdated Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated Show resolved Hide resolved
plugins/alembic/module/vtkF3DAlembicReader.cxx Outdated Show resolved Hide resolved
@mwestphal mwestphal requested review from Meakk and nyue November 21, 2023 17:11
@mwestphal mwestphal force-pushed the reader_alembic_uv_normal_support branch from fb7b3cf to a04c875 Compare November 21, 2023 18:17
@mwestphal mwestphal merged commit 153413c into f3d-app:master Nov 21, 2023
41 checks passed
@mwestphal mwestphal mentioned this pull request Dec 3, 2023
Open
5 tasks
mwestphal added a commit that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request #1069 from mwestphal/reader_alembic_uv_normal_support
e0f8c3a 
Reader alembic uv normal support
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request f3d-app#1069 from mwestphal/reader_alembic_uv_norm…
39b3d33 
…al_support

Reader alembic uv normal support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

@nyue nyue Awaiting requested review from nyue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwestphal @nyue @Meakk