Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve vtk cmake conf #142

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Improve vtk cmake conf #142

merged 2 commits into from
Dec 19, 2021

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Dec 12, 2021 •
edited
Loading

  • Disable wrapping completely
  • Use STDThread for SMP
  • Disable remote modules completelly
  • Introduce Cache versions in CI

@mwestphal mwestphal self-assigned this Dec 12, 2021
Meakk
Meakk reviewed Dec 12, 2021
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Meakk
Copy link
Contributor

Meakk commented Dec 12, 2021 •
edited
Loading

TestPLY segfaulting but it's unrelated.
Added to #92

@mwestphal
Copy link
Contributor Author

CMake Warning:
Manually-specified variables were not used by the project:

VTK_ENABLE_REMOTE_MODULES

mwestphal and others added 2 commits December 17, 2021 22:50
@mwestphal
Improve VTK cmake conf
168d9ce 
- Disable wrapping completely
- Use STDThread for SMP
- Disable remote modules completelly
@mwestphal
introducing cache versions
4c6fc05
@mwestphal mwestphal requested review from Meakk and removed request for Meakk December 17, 2021 21:51
@mwestphal mwestphal merged commit 6bf451d into f3d-app:master Dec 19, 2021
@mwestphal mwestphal deleted the improve_vtk_cmake_conf branch July 10, 2022 17:32
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@mwestphal
Merge pull request f3d-app#142 from mwestphal/improve_vtk_cmake_conf
c6fbda9 
Improve vtk cmake conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meakk Meakk Meakk approved these changes

Assignees

@mwestphal mwestphal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwestphal @Meakk