-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build VTK shared on all linux and macos #559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwestphal
commented
Jan 7, 2023
•
edited
Loading
edited
- VTK build shared libs on all linux
- VTK build shared libs on macos
- Small fixes for macos compat with build shared libs
- Set Windows PATH for upcoming shared libs (tested here: Draco shared libs #562)
- Set LD_LIBRARY_PATH for shared libs on linux
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 94.08% 94.06% -0.03%
==========================================
Files 97 97
Lines 4834 4834
==========================================
- Hits 4548 4547 -1
- Misses 286 287 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Meakk
reviewed
Jan 8, 2023
mwestphal
force-pushed
the
macos_shared
branch
from
January 8, 2023 11:18
2caf304
to
33dae1b
Compare
Meakk
approved these changes
Jan 8, 2023
mwestphal
added a commit
that referenced
this pull request
Feb 10, 2024
- VTK build shared libs on all linux - VTK build shared libs on macos - Small fixes for macos compat with build shared libs - Set Windows PATH for upcoming shared libs (tested here: #562) - Set LD_LIBRARY_PATH for shared libs on linux
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
- VTK build shared libs on all linux - VTK build shared libs on macos - Small fixes for macos compat with build shared libs - Set Windows PATH for upcoming shared libs (tested here: f3d-app#562) - Set LD_LIBRARY_PATH for shared libs on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.